Feature | Project Microsoft.SqlServer.Server separation phase 1 (MDS consumes MSS using netfx) #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavoudEshtehari
added
the
🆕 Public API
David-Engel
reviewed
Dec 15, 2021
| @@ -32,7 +35,7 @@ internal static SqlUdtInfo GetFromType(Type target) | |||
| SqlUdtInfo udtAttr = TryGetFromType(target); | |||
| if (udtAttr == null) | |||
| { | |||
| throw InvalidUdtException.Create(target, Strings.SqlUdtReason_NoUdtAttribute); | |||
| throw Server.InvalidUdtException.Create(target, Strings.SqlUdtReason_NoUdtAttribute); | |||
There was a problem hiding this comment.
If InvalidUstException bubbles up to users, this is another one we need to move to and get from Microsoft.SqlServer.Server. That's where it was originally:
DavoudEshtehari
force-pushed
the
MSqlServerSep
branch
from
47ccdca
to
d9e0720
Compare
DavoudEshtehari
force-pushed
the
MSqlServerSep
branch
from
d9e0720
to
aef40d0
Compare
DavoudEshtehari
commented
Dec 18, 2021
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/Server/SqlSer.cs
Outdated
Show resolved
Hide resolved
DavoudEshtehari
force-pushed
the
MSqlServerSep
branch
from
e2191db
to
268d0ca
Compare
…erverSep # Conflicts: # src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/Server/sqlser.cs
DavoudEshtehari
force-pushed
the
MSqlServerSep
branch
from
268d0ca
to
68edaa5
Compare
David-Engel
reviewed
Jan 19, 2022
| } | ||
|
|
||
| /// <include file='../../doc/snippets/Microsoft.Data.SqlClient.Server/InvalidUdtException.xml' path='docs/members[@name="InvalidUdtException"]/Create/*' /> | ||
| internal static InvalidUdtException Create(Type udtType, string resourceReason = "SqlUdtReason_NoUdtAttribute") |
There was a problem hiding this comment.
If we go ahead and open this up as public now, we can reference it without using reflection in the future once we drop netfx support (still years out). And we won't have to release a new version of MSS to do it.
There was a problem hiding this comment.
Thanks, David. I've missed the main goal of adding xml doc here. 😄 Done.
Co-authored-by: David Engel <dengel1012@gmail.com>
DavoudEshtehari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A rework on #1140 without any changes on the .Net Core project.
Microsoft.SqlServer.Server (new NuGet Package)
Provides Microsoft.SqlServer.Server (10 types) – targeting .NET Standard 2.0
Types forwarded to System.Data - for .NET Framework 4.6.1+