Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include new packages in nuspec file #1266

Merged
merged 2 commits into from
Sep 21, 2021

Conversation

DavoudEshtehari
Copy link
Member

@DavoudEshtehari DavoudEshtehari commented Sep 20, 2021

  • Alphabetically has been sorted.

@DavoudEshtehari DavoudEshtehari changed the title Add new packages in Nu file Add new packages in nuspec file Sep 20, 2021
@DavoudEshtehari DavoudEshtehari changed the title Add new packages in nuspec file Include new packages in nuspec file Sep 20, 2021
@johnnypham
Copy link
Contributor

The following are present in netcore csproj but still missing in the changes:

  <PackageReference Include="System.Threading.Tasks" Version="$(SystemThreadingTasksVersion)" />
  <PackageReference Include="System.Memory" Version="$(SystemMemoryVersion)" />
  <PackageReference Include="System.Globalization" Version="$(SystemGlobalizationVersion)" />
  <PackageReference Include="System.Xml.ReaderWriter" Version="$(SystemXmlReaderWriterVersion)" />

Should we include every package? @cheenamalhotra

@cheenamalhotra
Copy link
Member

The following are present in netcore csproj but still missing in the changes:

  <PackageReference Include="System.Threading.Tasks" Version="$(SystemThreadingTasksVersion)" />
  <PackageReference Include="System.Memory" Version="$(SystemMemoryVersion)" />
  <PackageReference Include="System.Globalization" Version="$(SystemGlobalizationVersion)" />
  <PackageReference Include="System.Xml.ReaderWriter" Version="$(SystemXmlReaderWriterVersion)" />

Should we include every package? @cheenamalhotra

Good observation, I could build netcore project without these packages included.
If they're not needed, they could be removed perhaps? Can we try to remove them in this PR?

@DavoudEshtehari
Copy link
Member Author

All the pipelines passed without those 4 package references on .NET Core, yesterday. Updated Versions.props too.

@ErikEJ
Copy link
Contributor

ErikEJ commented Sep 21, 2021

You could consider building the nuget package using msbuild...

@JRahnama
Copy link
Member

You could consider building the nuget package using msbuild...

that is how we build the driver and tests, if I have got your point correct. Building driver using msbuild -p:Configuration=$(Configuration) will also lead to create a folder named package with the created nuget inside it.

@cheenamalhotra
Copy link
Member

You could consider building the nuget package using msbuild...

that is how we build the driver and tests, if I have got your point correct. Building driver using msbuild -p:Configuration=$(Configuration) will also lead to create a folder named package with the created nuget inside it.

That's our scripts doing all the work. I think @ErikEJ is referring to msbuild -t:pack (Link).

@ErikEJ
Copy link
Contributor

ErikEJ commented Sep 21, 2021

Yes, I meant define the package in the .csproj, this also makes dependency management much simpler

@cheenamalhotra
Copy link
Member

Our process is distributed since we need to Sign the DLLs before packing when we build release packages. For that reason we build and pack in different steps, but we can investigate any possibilities to ease this process.

@DavoudEshtehari DavoudEshtehari merged commit 478519b into dotnet:main Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants