Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share SqlUdtInfo #1040

Merged
merged 2 commits into from
Apr 28, 2021
Merged

Share SqlUdtInfo #1040

merged 2 commits into from
Apr 28, 2021

Conversation

Wraith2
Copy link
Contributor

@Wraith2 Wraith2 commented Apr 16, 2021

Simple move of netcore SqlUdtInfo version to shared and minor style update.

@cheenamalhotra cheenamalhotra added this to the 3.0.0-preview3 milestone Apr 28, 2021
cheenamalhotra
cheenamalhotra approved these changes Apr 28, 2021
View reviewed changes
Copy link
Member

@cheenamalhotra cheenamalhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit cleanup needed

src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj Outdated Show resolved Hide resolved
@cheenamalhotra cheenamalhotra merged commit 4f3397d into dotnet:main Apr 28, 2021
@Wraith2 Wraith2 deleted the combine23 branch July 18, 2021 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

@johnnypham johnnypham johnnypham approved these changes

@DavoudEshtehari DavoudEshtehari Awaiting requested review from DavoudEshtehari

@JRahnama JRahnama Awaiting requested review from JRahnama

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0-preview3
Development

Successfully merging this pull request may close these issues.
3 participants
@Wraith2 @cheenamalhotra @johnnypham