Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dot name restrictions mean we can't clean up randomly generated docker volumes #495

Closed
lukemarsden opened this issue Jul 10, 2018 · 1 comment
Labels

Comments

@lukemarsden
Copy link
Collaborator

a VOLUME defined in a Dockerfile started with --volume-driver dm will yield something like this

Current remote: local (use 'dm remote -v' to list and 'dm remote switch' to switch)

  DOT                                                               BRANCH  SERVER            CONTAINERS  SIZE       COMMITS  DIRTY
* 9b865265652eb416b8fc4022d177e8c434c4c843a616a7b4f7f11f6a788c4617  master  c1259a93e0498e4d              25.00 kiB  0        25.00 kiB

the dot fails to pass the new dot name rules though, so can't be deleted

luke@dot:~/Projects/Subtree/dotscience$ for X in $(dm list -H |cut -f 1); do dm dot delete -f $X; done
Response '{"jsonrpc":"2.0","error":{"code":-32000,"message":"Invalid dot name 9b865265652eb416b8fc4022d177e8c434c4c843a616a7b4f7f11f6a788c4617","data":null},"id":8674665223082153551}
' yields error Invalid dot name 9b865265652eb416b8fc4022d177e8c434c4c843a616a7b4f7f11f6a788c4617

I think we should probably just extend the dot name rules to make the anonymous volumes docker requests allowable. the alternative: refusing to create such dots, will only break docker apps which use VOLUME.

lukemarsden added a commit that referenced this issue Jul 10, 2018
…s makes anonymous docker volumes (which are randomly generated 64 character uuids) valid names, so that we can delete them
@lukemarsden
Copy link
Collaborator Author

fixed!

lukemarsden added a commit that referenced this issue Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant