Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show replication status for a dot if not an admin #460

Closed
Godley opened this issue Jun 18, 2018 · 0 comments
Closed

Don't show replication status for a dot if not an admin #460

Godley opened this issue Jun 18, 2018 · 0 comments
Labels

Comments

@Godley
Copy link
Contributor

Godley commented Jun 18, 2018

at the mo if a user is not an admin for a cluster and they run dm dot show <whatever>, they get:

Replication Status:
unable to fetch replication status (Response '{"jsonrpc":"2.0","error":{"code":-32000,"message":"Userid 9a74c7a2-609d-4d17-54d7-831e1a624d01 is not admin user","data":null},"id":3510942875414458836}
' yields error Userid 9a74c7a2-609d-4d17-54d7-831e1a624d01 is not admin user), proceeding...

or similar. Would be better to detect the error and not include replication status in dm dot show's output.

prisamuel pushed a commit that referenced this issue Jul 13, 2018
Also introduced unit-tests in the dm client!!!

See folder dm/test for examples.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants