Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(response-cache): use ETag to use HTTP caching strategy #2252

Merged
merged 17 commits into from
Feb 17, 2023

Conversation

ardatan
Copy link
Collaborator

@ardatan ardatan commented Dec 26, 2022

Closes #2080

@changeset-bot
Copy link

changeset-bot bot commented Dec 26, 2022

🦋 Changeset detected

Latest commit: 751fe1d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-yoga/plugin-response-cache Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 26, 2022

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-yoga/plugin-response-cache 1.7.0-alpha-20230217113302-751fe1db npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Dec 26, 2022

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 203854      ✗ 0     
     data_received..................: 25 MB   846 kB/s
     data_sent......................: 18 MB   612 kB/s
     http_req_blocked...............: avg=1.22µs   min=800ns    med=1µs     max=2.38ms  p(90)=1.5µs    p(95)=1.8µs   
     http_req_connecting............: avg=21ns     min=0s       med=0s      max=2.23ms  p(90)=0s       p(95)=0s      
   ✓ http_req_duration..............: avg=219.18µs min=151.9µs  med=196.8µs max=20.77ms p(90)=237.4µs  p(95)=269.3µs 
       { expected_response:true }...: avg=219.18µs min=151.9µs  med=196.8µs max=20.77ms p(90)=237.4µs  p(95)=269.3µs 
     http_req_failed................: 0.00%   ✓ 0           ✗ 101927
     http_req_receiving.............: avg=17.14µs  min=10.4µs   med=14.9µs  max=8.63ms  p(90)=20.9µs   p(95)=24.29µs 
     http_req_sending...............: avg=7.02µs   min=4.7µs    med=5.6µs   max=4.03ms  p(90)=7.9µs    p(95)=10.1µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s      max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=195.01µs min=131.39µs med=175.8µs max=20.37ms p(90)=208.79µs p(95)=236.9µs 
     http_reqs......................: 101927  3397.420057/s
     iteration_duration.............: avg=289.38µs min=208.7µs  med=259.7µs max=21.12ms p(90)=315.4µs  p(95)=350.79µs
     iterations.....................: 101927  3397.420057/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

@github-actions
Copy link
Contributor

github-actions bot commented Dec 26, 2022

🚀 Website Preview

The latest changes to the website are available as preview in: https://ef6ebabe.graphql-yoga.pages.dev

@ardatan ardatan changed the title feat(response-cache): use ETag to use HTTP caching strategy DO NOT MERGE: feat(response-cache): use ETag to use HTTP caching strategy Feb 14, 2023
@ardatan ardatan changed the title DO NOT MERGE: feat(response-cache): use ETag to use HTTP caching strategy feat(response-cache): use ETag to use HTTP caching strategy Feb 15, 2023
ardatan and others added 2 commits February 15, 2023 15:11
Co-authored-by: Laurin Quast <laurinquast@googlemail.com>
@ardatan ardatan requested a review from n1ru4l February 15, 2023 12:34
ardatan and others added 3 commits February 16, 2023 17:19
Co-authored-by: Laurin Quast <laurinquast@googlemail.com>
Co-authored-by: Laurin Quast <laurinquast@googlemail.com>
Copy link
Collaborator

@n1ru4l n1ru4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍🚀🎉

@n1ru4l n1ru4l merged commit 4e824b3 into main Feb 17, 2023
@n1ru4l n1ru4l deleted the etag-response-cache branch February 17, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ETag/If-None-Match plugin
4 participants