Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable introspection plugin #2231

Merged
merged 5 commits into from
Dec 22, 2022
Merged

Conversation

n1ru4l
Copy link
Collaborator

@n1ru4l n1ru4l commented Dec 16, 2022

Tests are failing because the useValidationCache plugin from envelope does not include the rules in the cache key.

See n1ru4l/envelop#1598

Closes #2188

@changeset-bot
Copy link

changeset-bot bot commented Dec 16, 2022

🦋 Changeset detected

Latest commit: bdbc1f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
graphql-yoga Patch
@graphql-yoga/common Patch
@graphql-yoga/node Patch
apollo-federation-gateway-with-yoga Patch
apollo-subgraph-with-yoga Patch
graphql-lambda Patch
cloudflare-advanced Patch
cloudflare Patch
hackernews Patch
hello-world-benchmark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2022

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 86240       ✗ 0    
     data_received..................: 12 MB   404 kB/s
     data_sent......................: 5.0 MB  165 kB/s
     http_req_blocked...............: avg=2.6µs    min=1.1µs   med=2µs      max=2.41ms  p(90)=2.6µs    p(95)=3.4µs   
     http_req_connecting............: avg=50ns     min=0s      med=0s       max=2.19ms  p(90)=0s       p(95)=0s      
   ✓ http_req_duration..............: avg=557.63µs min=285.8µs med=466.65µs max=26.43ms p(90)=680.51µs p(95)=867.61µs
       { expected_response:true }...: avg=557.63µs min=285.8µs med=466.65µs max=26.43ms p(90)=680.51µs p(95)=867.61µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 43120
     http_req_receiving.............: avg=37.3µs   min=16.6µs  med=30.2µs   max=7.28ms  p(90)=47.9µs   p(95)=59.1µs  
     http_req_sending...............: avg=14.46µs  min=5.8µs   med=9.6µs    max=5.58ms  p(90)=19.9µs   p(95)=27.5µs  
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=505.85µs min=256.9µs med=419.95µs max=26.25ms p(90)=615.6µs  p(95)=792.32µs
     http_reqs......................: 43120   1437.260004/s
     iteration_duration.............: avg=686.49µs min=353.8µs med=590.3µs  max=29.14ms p(90)=837.21µs p(95)=1.04ms  
     iterations.....................: 43120   1437.260004/s
     vus............................: 1       min=1         max=1  
     vus_max........................: 1       min=1         max=1  

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2022

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-yoga/common 3.1.2-alpha-20221222112044-083a66e0 npm ↗︎ unpkg ↗︎
graphql-yoga 3.1.2-alpha-20221222112044-083a66e0 npm ↗︎ unpkg ↗︎
@graphql-yoga/node 3.1.2-alpha-20221222112044-083a66e0 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apollo-inline-trace 1.1.2-alpha-20221222112044-083a66e0 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apq 1.1.2-alpha-20221222112044-083a66e0 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-defer-stream 1.1.2-alpha-20221222112044-083a66e0 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-disable-introspection 0.0.1-alpha-20221222112044-083a66e0 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-persisted-operations 1.1.2-alpha-20221222112044-083a66e0 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-prometheus 1.1.2-alpha-20221222112044-083a66e0 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-response-cache 1.1.2-alpha-20221222112044-083a66e0 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-sofa 1.1.2-alpha-20221222112044-083a66e0 npm ↗︎ unpkg ↗︎
@graphql-yoga/render-graphiql 3.1.2-alpha-20221222112044-083a66e0 npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2022

🚀 Website Preview

The latest changes to the website are available as preview in: https://84d2ca04.graphql-yoga.pages.dev

@n1ru4l n1ru4l force-pushed the feat-disable-introspection-plugin branch from 267e2f7 to 6a3aaf6 Compare December 22, 2022 11:13
@n1ru4l n1ru4l merged commit c5b1cc4 into main Dec 22, 2022
@n1ru4l n1ru4l deleted the feat-disable-introspection-plugin branch December 22, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[disable introspection] based on authorization headers
2 participants