Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: log level via config #2085

Merged
merged 3 commits into from
Nov 11, 2022
Merged

feat: log level via config #2085

merged 3 commits into from
Nov 11, 2022

Conversation

n1ru4l
Copy link
Collaborator

@n1ru4l n1ru4l commented Nov 11, 2022

This allows providing a log-level string to the logging option.

It also changes the behavior that allows the DEBUG environment variable mixture with different log levels. If the DEBUG environment variable is specified, all logs (prior log levels) should be logged instead.

I don't really see a use case where I want debug logs but not info and/or warn logs.

@changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2022

⚠️ No Changeset found

Latest commit: de35978

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2022

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 197302      ✗ 0    
     data_received..................: 29 MB   980 kB/s
     data_sent......................: 11 MB   378 kB/s
     http_req_blocked...............: avg=1.16µs   min=799ns    med=1µs      max=4.02ms  p(90)=1.4µs    p(95)=1.6µs   
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=108.1µs p(90)=0s       p(95)=0s      
   ✓ http_req_duration..............: avg=235.83µs min=168.59µs med=214.99µs max=24.04ms p(90)=260.69µs p(95)=290.89µs
       { expected_response:true }...: avg=235.83µs min=168.59µs med=214.99µs max=24.04ms p(90)=260.69µs p(95)=290.89µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 98651
     http_req_receiving.............: avg=17.84µs  min=10.6µs   med=16.29µs  max=6.57ms  p(90)=20.39µs  p(95)=22.7µs  
     http_req_sending...............: avg=5.67µs   min=3.9µs    med=4.7µs    max=4.8ms   p(90)=6.2µs    p(95)=8.4µs   
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=212.3µs  min=147.59µs med=193.69µs max=23.64ms p(90)=233.79µs p(95)=259.99µs
     http_reqs......................: 98651   3288.214201/s
     iteration_duration.............: avg=299.64µs min=219.79µs med=277.49µs max=24.27ms p(90)=332.59µs p(95)=369.29µs
     iterations.....................: 98651   3288.214201/s
     vus............................: 1       min=1         max=1  
     vus_max........................: 1       min=1         max=1  

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2022

🚀 Website Preview

The latest changes to the website are available as preview in: https://ba0a0802.graphql-yoga.pages.dev

@theguild-bot theguild-bot mentioned this pull request Nov 11, 2022
@n1ru4l n1ru4l added this to the v3 milestone Nov 11, 2022
@ardatan ardatan merged commit 943fa74 into main Nov 11, 2022
@ardatan ardatan deleted the feat-log-level-config branch November 11, 2022 16:42
ardatan pushed a commit that referenced this pull request Nov 11, 2022
* feat: log level via config

* add missing import

* fix cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants