feat: log unexpected GraphQL errors #2084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
n1ru4l
commented
Nov 11, 2022
Comment on lines
+242
to
+257
| maskError: (error, message) => { | ||
| const newError = maskErrorFn( | ||
| { | ||
| error, | ||
| message, | ||
| isDev: this.maskedErrorsOpts?.isDev ?? false, | ||
| }, | ||
| message, | ||
| ) | ||
|
|
||
| if (newError !== error) { | ||
| this.logger.error(error) | ||
| } | ||
|
|
||
| return newError | ||
| }, |
There was a problem hiding this comment.
In case error masking is disabled that means that every error is an expected error - thus we shouldn't log any error.
n1ru4l
commented
Nov 11, 2022
Comment on lines
+4
to
+45
| const logLevelScores: Record<LogLevel | 'silent', number> = { | ||
| debug: 0, | ||
| info: 1, | ||
| warn: 2, | ||
| error: 3, | ||
| silent: 4, | ||
| } | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-empty-function | ||
| const noop = () => {} | ||
|
|
||
| /** | ||
| * utility for creating a conditional logger for tests. | ||
| */ | ||
| export const createCustomLogger = ( | ||
| logLevel: LogLevel | 'silent' = globalThis?.process.env['DEBUG'] === '1' | ||
| ? 'debug' | ||
| : 'info', | ||
| ) => { | ||
| const score = logLevelScores[logLevel] | ||
| return { | ||
| debug: score > logLevelScores.debug ? noop : debugLog, | ||
| info: score > logLevelScores.info ? noop : infoLog, | ||
| warn: score > logLevelScores.warn ? noop : warnLog, | ||
| error: score > logLevelScores.error ? noop : errorLog, | ||
| } | ||
| } | ||
|
|
||
| const consoleLog = (...args: Array<any>) => console.log(...args) | ||
|
|
||
| const debugLog = console.debug | ||
| ? (...args: Array<any>) => console.debug(...args) | ||
| : consoleLog | ||
| const infoLog = console.info | ||
| ? (...args: Array<any>) => console.info(...args) | ||
| : consoleLog | ||
| const warnLog = console.warn | ||
| ? (...args: Array<any>) => console.warn(...args) | ||
| : consoleLog | ||
| const errorLog = console.error | ||
| ? (...args: Array<any>) => console.error(...args) | ||
| : consoleLog |
There was a problem hiding this comment.
@kamilkisiela We can use this logger implementation in hive in case my proposal does not make it into yoga v3.
✅ Benchmark Results |
🚀 Website PreviewThe latest changes to the website are available as preview in: https://260d9549.graphql-yoga.pages.dev |
ardatan
approved these changes
Nov 11, 2022
kamilkisiela
approved these changes
Nov 11, 2022
enisdenjo
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1584