Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: re-export specific things from @envelop/core #2061

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

saihaj
Copy link
Collaborator

@saihaj saihaj commented Nov 8, 2022

after some thought I think we should really only export selective things from @envelop/core instead of exporting everything. This way we avoid any breaking changes downstream envelop impacting us.

closes #2039

@changeset-bot
Copy link

changeset-bot bot commented Nov 8, 2022

🦋 Changeset detected

Latest commit: 34dd29a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
graphql-yoga Major
@graphql-yoga/common Patch
@graphql-yoga/node Patch
@graphql-yoga/render-graphiql Major
@graphql-yoga/plugin-apollo-inline-trace Major
@graphql-yoga/plugin-apq Major
@graphql-yoga/plugin-defer-stream Major
@graphql-yoga/plugin-persisted-operations Major
@graphql-yoga/plugin-prometheus Major
@graphql-yoga/plugin-response-cache Major
@graphql-yoga/plugin-sofa Major
apollo-federation-gateway-with-yoga Patch
apollo-subgraph-with-yoga Patch
graphql-lambda Patch
cloudflare-advanced Patch
cloudflare Patch
hackernews Patch
hello-world-benchmark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 97802       ✗ 0    
     data_received..................: 15 MB   486 kB/s
     data_sent......................: 5.6 MB  187 kB/s
     http_req_blocked...............: avg=2.24µs   min=1.2µs    med=1.9µs    max=980.79µs p(90)=2.4µs    p(95)=2.9µs   
     http_req_connecting............: avg=15ns     min=0s       med=0s       max=753.89µs p(90)=0s       p(95)=0s      
   ✓ http_req_duration..............: avg=490.32µs min=294.09µs med=417.49µs max=24.43ms  p(90)=563.69µs p(95)=683.99µs
       { expected_response:true }...: avg=490.32µs min=294.09µs med=417.49µs max=24.43ms  p(90)=563.69µs p(95)=683.99µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 48901
     http_req_receiving.............: avg=33.06µs  min=18.2µs   med=26.8µs   max=6.81ms   p(90)=41.7µs   p(95)=47.4µs  
     http_req_sending...............: avg=12.01µs  min=6.1µs    med=8.5µs    max=3.76ms   p(90)=19.5µs   p(95)=21.4µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=445.23µs min=260.39µs med=377.79µs max=24.29ms  p(90)=507.59µs p(95)=621.99µs
     http_reqs......................: 48901   1629.936797/s
     iteration_duration.............: avg=605.64µs min=369.79µs med=528.59µs max=25.65ms  p(90)=696.29µs p(95)=836.39µs
     iterations.....................: 48901   1629.936797/s
     vus............................: 1       min=1         max=1  
     vus_max........................: 1       min=1         max=1  

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-yoga/apollo-link 1.0.0-alpha-20221108222818-8ea20c06 npm ↗︎ unpkg ↗︎
@graphql-yoga/urql-exchange 1.0.0-alpha-20221108222818-8ea20c06 npm ↗︎ unpkg ↗︎
@graphql-yoga/common 3.0.0-alpha-20221108222818-8ea20c06 npm ↗︎ unpkg ↗︎
@graphql-yoga/redis-event-target 1.0.0-alpha-20221108222818-8ea20c06 npm ↗︎ unpkg ↗︎
@graphql-yoga/typed-event-target 1.0.0-alpha-20221108222818-8ea20c06 npm ↗︎ unpkg ↗︎
@graphql-yoga/graphiql 3.0.0-alpha-20221108222818-8ea20c06 npm ↗︎ unpkg ↗︎
graphql-yoga 3.0.0-alpha-20221108222818-8ea20c06 npm ↗︎ unpkg ↗︎
@graphql-yoga/node 3.0.0-alpha-20221108222818-8ea20c06 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apollo-inline-trace 1.0.0-alpha-20221108222818-8ea20c06 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apq 1.0.0-alpha-20221108222818-8ea20c06 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-defer-stream 1.0.0-alpha-20221108222818-8ea20c06 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-persisted-operations 1.0.0-alpha-20221108222818-8ea20c06 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-prometheus 1.0.0-alpha-20221108222818-8ea20c06 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-response-cache 1.0.0-alpha-20221108222818-8ea20c06 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-sofa 1.0.0-alpha-20221108222818-8ea20c06 npm ↗︎ unpkg ↗︎
@graphql-yoga/render-graphiql 3.0.0-alpha-20221108222818-8ea20c06 npm ↗︎ unpkg ↗︎
@graphql-yoga/subscription 3.0.0-alpha-20221108222818-8ea20c06 npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

🚀 Website Preview

The latest changes to the website are available as preview in: https://aab27145.graphql-yoga.pages.dev

@theguild-bot theguild-bot mentioned this pull request Nov 9, 2022
Copy link
Collaborator

@enisdenjo enisdenjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What don't we want to export? Anything removed that might be breaking?

@n1ru4l
Copy link
Collaborator

n1ru4l commented Nov 11, 2022

@enisdenjo Everything that is not really needed because it is internal or might cause weird stuff. E.g. useMaskedErrors does not need to be re-exported as we already have it built in.

@ardatan ardatan merged commit 3759d27 into main Nov 11, 2022
@ardatan ardatan deleted the saihaj/do-not-export-everythin branch November 11, 2022 16:41
@ardatan ardatan restored the saihaj/do-not-export-everythin branch November 11, 2022 16:47
ardatan added a commit that referenced this pull request Nov 11, 2022
ardatan added a commit that referenced this pull request Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v3] graphql-yoga module should not export useMaskedErrors
4 participants