Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): accept POST requests as JSON by default again #1636

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

ardatan
Copy link
Collaborator

@ardatan ardatan commented Aug 19, 2022

This PR reverts the breaking change introduced in 2.8.0(minor release)

@changeset-bot
Copy link

changeset-bot bot commented Aug 19, 2022

🦋 Changeset detected

Latest commit: 70d8f92

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@graphql-yoga/common Patch
cloudflare-advanced Patch
cloudflare Patch
service-worker Patch
sveltekit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2022

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-yoga/common 2.12.8-alpha-20220823123003-08c4605c npm ↗︎ unpkg ↗︎
graphql-yoga 2.13.9-alpha-20220823123003-08c4605c npm ↗︎ unpkg ↗︎
@graphql-yoga/node 2.13.9-alpha-20220823123003-08c4605c npm ↗︎ unpkg ↗︎
@graphql-yoga/render-graphiql 2.13.8-alpha-20220823123003-08c4605c npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2022

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 220724      ✗ 0     
     data_received..................: 29 MB   979 kB/s
     data_sent......................: 13 MB   423 kB/s
     http_req_blocked...............: avg=1.13µs   min=700ns    med=1µs      max=3.18ms   p(90)=1.4µs    p(95)=1.7µs   
     http_req_connecting............: avg=7ns      min=0s       med=0s       max=782.59µs p(90)=0s       p(95)=0s      
   ✓ http_req_duration..............: avg=202.99µs min=131.19µs med=181.39µs max=18.29ms  p(90)=228.79µs p(95)=256.69µs
       { expected_response:true }...: avg=202.99µs min=131.19µs med=181.39µs max=18.29ms  p(90)=228.79µs p(95)=256.69µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 110362
     http_req_receiving.............: avg=17.87µs  min=10.2µs   med=16.59µs  max=6.29ms   p(90)=21.39µs  p(95)=25.39µs 
     http_req_sending...............: avg=5.87µs   min=3.89µs   med=4.59µs   max=4.16ms   p(90)=6.8µs    p(95)=10.2µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=179.25µs min=115.49µs med=159.69µs max=18.2ms   p(90)=200.79µs p(95)=225.29µs
     http_reqs......................: 110362  3678.580571/s
     iteration_duration.............: avg=266.92µs min=184.99µs med=242.39µs max=19.42ms  p(90)=303.59µs p(95)=336.69µs
     iterations.....................: 110362  3678.580571/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

Copy link
Collaborator

@n1ru4l n1ru4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nedd to resolve the lockfile issues

@n1ru4l n1ru4l merged commit 38c7c13 into master Aug 23, 2022
@n1ru4l n1ru4l deleted the revert-content-type branch August 23, 2022 12:37
saihaj added a commit that referenced this pull request Aug 30, 2022
* docs: added file upload example to save file in disk (#1477)

* updated: file upload example to save file in disk using fs

* added: fs module import

* added: path module import

* docs: fix typos (#1492)

* fix(deps): update all non-major dependencies (master) (#1480)

* fix(deps): update all non-major dependencies

* Fix tests

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com>

* fix(deps): update envelop (#1495)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update all non-major dependencies (#1494)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update file-uploads.mdx (#1501)

* docs: fix typos (#1498)

* Bump @whatwg-node/fetch to get the latest fixes (#1493)

* chore(release): update monorepo packages versions (#1502)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore(deps): update all non-major dependencies (master) (#1517)

* chore(deps): update all non-major dependencies

* chore: bump "@envelop/live-query"

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Laurin Quast <laurinquast@googlemail.com>

* chore(deps): update all non-major dependencies (#1528)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency puppeteer to v16 (#1531)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix: typescript commonjs resolution (#1543)

* chore(release): update monorepo packages versions (#1546)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix(deps): update envelop (#1549)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update yarn.lock

* fix(deps): update dependency framer-motion to v7 (#1540)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update all non-major dependencies (#1539)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency puppeteer to v16.1.0 (#1555)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* docs: fix bad redis import (#1554)

There is an error with import. 
```
'Redis' cannot be used as a value because it was exported using 'export type'.ts(1362)
```
Take a look here https://github.com/luin/ioredis

* chore(deps): update all non-major dependencies (#1559)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update all non-major dependencies (#1561)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update all non-major dependencies to v2.37.0 (#1571)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update subscriptions.mdx (#1572)

* fix(deps): update dependency @graphql-tools/schema to v9 (#1570)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update all non-major dependencies (#1573)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update algolia-lockfile.json

* fix(deps): update dependency pino-pretty to v9 (#1574)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency esbuild to v0.15.1 (#1577)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency shiki to ^0.11.0 (#1580)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update all non-major dependencies (#1582)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update all non-major dependencies (#1591)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency eslint to v8.22.0 (#1593)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency esbuild to v0.15.3 (#1594)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency html-minifier-terser to v7.0.0 (#1596)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update all non-major dependencies (#1598)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @pothos/core to v3.15.0 (#1599)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix: apply the useHTTPValidationError plugin last (#1600)

* test: add failing test

* fix: put the useHTTPValidationError plugin last

* chore: add changeset

* fix: upgrade envelop (#1603)

* fix: upgrade envelop

* chore: add test

* use shared pipelines and latest repo setup (#1605)

* chore(release): update monorepo packages versions (#1602)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix(deps): update all non-major dependencies (master) (#1611)

* fix(deps): update all non-major dependencies

* chore(dependencies): updated changesets for modified dependencies

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix(deps): update all non-major dependencies (#1614)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update all non-major dependencies (#1618)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Unopinionated vscode settings (#1617)

* unopinionated

* some recommendations

* chore(deps): update all non-major dependencies (#1627)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* ci: use shared actions (#1626)

* chore(release): update monorepo packages versions (#1613)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* example: add graphql-armor (#1620)

* feat(example): add graphql-armor

* chore(example/graphql-armor): update example query + description

* chore(example/graphql-armor): add installation snippet

* chore(example/graphql-armor): bump armor version

* chore(deps): bump graphql armor

* chore(deps): bump graphql armor

* chore(deps): update dependency netlify-cli to v11 (#1628)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix: graphiql (#1634)

* fix: graphiql

* fix: test

* remove html test

* chore(release): update monorepo packages versions (#1635)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore(deps): update all non-major dependencies (#1637)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @sveltejs/adapter-auto to v1.0.0-next.65 (#1640)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update all non-major dependencies (#1645)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(common): accept POST requests as JSON by default again (#1636)

* chore(release): update monorepo packages versions (#1651)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix(deps): update dependency next-i18next to v12 (#1643)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* GraphQL Yoga - New website (#1537)

* bootstrap

fix menu

* features

* integrations

* migration

* advanced

* basic

* fix title

* fix

* rebase conflicts

* temp

* update components

* yeah

* chore(dependencies): updated changesets for modified dependencies

* npx yarn deduplicate

Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Update algolia-lockfile.json

* chore(deps): update all non-major dependencies (master) (#1649)

* chore(deps): update all non-major dependencies

* chore(dependencies): updated changesets for modified dependencies

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* upgrade and fix Deno example (#1667)

* upgrade and fix Deno example

* Update

* fix(common): accept the server context if Yoga instance is used as a Request handler

Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com>

* chore(release): update monorepo packages versions (#1652)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Respect Envelop's OnPluginInit's addPlugin method (#1671)

* chore(release): update monorepo packages versions (#1673)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore(deps): update all non-major dependencies (master) (#1658)

* chore(deps): update all non-major dependencies

* chore(dependencies): updated changesets for modified dependencies

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: use correct version for graphql-ws (#1680)

* make build pass

* some fixes

* fix: integration test

* one test to go

* fix build issues

* include schema and check error extensions too

* ci: remove node 12

Co-authored-by: Salman Dabbakuti <dabbakutisalman@gmail.com>
Co-authored-by: Laurin Quast <laurinquast@googlemail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com>
Co-authored-by: matsuda-argano <106219284+matsuda-argano@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Adam Tkaczyk <adam@tkaczyk.dev>
Co-authored-by: Dotan Simha <dotansimha@gmail.com>
Co-authored-by: Denis Badurina <badurinadenis@gmail.com>
Co-authored-by: c3b5aw <spyk.developpeur@gmail.com>
Co-authored-by: Tuval Simha <tuval.simha@Gmail.com>
Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
Co-authored-by: Paul <paul.cowan@cutting.scot>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants