Go

dotansimha · Jul 24, 2022 · d17a1f3 · d17a1f3
1 parent 6a3db84
commit d17a1f3
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 7 deletions.
diff --git a/examples/sveltekit/__tests__/test.ts b/examples/sveltekit/__tests__/test.ts
@@ -17,7 +17,7 @@ let toSkip = false;
 
 describe('SvelteKit integration', () => {
 	beforeAll(async () => {
-		console.time('Setup SvelteKit tests');
+		// console.time('Setup SvelteKit tests');
 
 		const nodeVersion = execSync('node -v').toString();
 		if (nodeVersion.includes('v12')) {
@@ -49,7 +49,7 @@ describe('SvelteKit integration', () => {
 		}
 
 		// How long it took?
-		console.timeEnd('Setup SvelteKit tests');
+		// console.timeEnd('Setup SvelteKit tests');
 	}, timings.setup.total);
 
 	beforeEach(async () => {

diff --git a/packages/graphiql/index.html b/packages/graphiql/index.html
@@ -21,7 +21,9 @@
     <script type="module">
       import * as yogaGraphiQL from './src/bundle.tsx'
       const container = window.document.querySelector('#root')
-      yogaGraphiQL.renderYogaGraphiQL(container)
+      yogaGraphiQL.renderYogaGraphiQL(container, {
+        endpoint: '/graphql',
+      })
     </script>
   </body>
 </html>
diff --git a/packages/graphiql/vite.config.ts b/packages/graphiql/vite.config.ts
@@ -11,6 +11,9 @@ export default defineConfig({
       '/graphql': 'http://localhost:4000',
     },
   },
+  define: {
+    'process.env.NODE_ENV': '"production"',
+  },
   build: {
     lib: {
       entry: path.resolve(__dirname, 'src', 'bundle.tsx'),
@@ -19,7 +22,9 @@ export default defineConfig({
     },
     rollupOptions: {
       output: {
-        inlineDynamicImports: true,
+        /** prevent code-splitting */
+        inlineDynamicImports: false,
+        manualChunks: () => '_.js',
       },
     },
   },

diff --git a/packages/render-graphiql/scripts/yoga-bundle-string.mjs b/packages/render-graphiql/scripts/yoga-bundle-string.mjs
@@ -4,7 +4,7 @@ import { fileURLToPath } from 'url'
 
 const directoryName = path.dirname(fileURLToPath(import.meta.url))
 const inputPath = path.resolve(directoryName, '..', '..', 'graphiql', 'dist')
-const jsFile = path.resolve(inputPath, 'yoga-graphiql.es.js')
+const jsFile = path.resolve(inputPath, 'yoga-graphiql.umd.js')
 const cssFile = path.resolve(inputPath, 'style.css')
 
 const outFile = path.resolve(directoryName, '..', 'src', 'graphiql.ts')

diff --git a/packages/render-graphiql/src/index.ts b/packages/render-graphiql/src/index.ts
@@ -16,9 +16,9 @@ export const renderGraphiQL = (opts?: GraphiQLOptions) => /* HTML */ `
       <noscript>You need to enable JavaScript to run this app.</noscript>
       <div id="root"></div>
 
-      <script type="module">
+      <script>
         ${js}
-        renderYogaGraphiQL(
+        YogaGraphiQL.renderYogaGraphiQL(
           window.document.querySelector('#root'),
           ${JSON.stringify(opts ?? {})},
         )