no need to graphql parameters

dotansimha · Jul 28, 2022 · 6478015 · 6478015
1 parent 9fea97a
commit 6478015
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 15 deletions.
diff --git a/packages/plugins/response-cache/__tests__/response-cache.spec.ts b/packages/plugins/response-cache/__tests__/response-cache.spec.ts
@@ -56,7 +56,7 @@ it('cache a query operation per session', async () => {
   const yoga = createYoga({
     plugins: [
       useResponseCache({
-        session: (_, request) => request.headers.get('x-session-id') ?? null,
+        session: (request) => request.headers.get('x-session-id') ?? null,
         includeExtensionMetadata: true,
       }),
     ],

diff --git a/packages/plugins/response-cache/src/index.ts b/packages/plugins/response-cache/src/index.ts
@@ -5,23 +5,14 @@ import {
   useResponseCache as useEnvelopResponseCache,
   UseResponseCacheParameter as UseEnvelopResponseCacheParameter,
 } from '@envelop/response-cache'
-import {
-  GraphQLParams,
-  Maybe,
-  Plugin,
-  PromiseOrValue,
-  YogaInitialContext,
-} from 'graphql-yoga'
+import { Maybe, Plugin, PromiseOrValue, YogaInitialContext } from 'graphql-yoga'
 
 export type UseResponseCacheParameter = Omit<
   UseEnvelopResponseCacheParameter,
   'getDocumentString' | 'session'
 > & {
-  session: (
-    params: GraphQLParams,
-    request: Request,
-  ) => PromiseOrValue<Maybe<string>>
-  enabled?: (params: GraphQLParams, request: Request) => boolean
+  session: (request: Request) => PromiseOrValue<Maybe<string>>
+  enabled?: (request: Request) => boolean
 }
 
 const operationIdByRequest = new WeakMap<Request, string>()
@@ -49,12 +40,12 @@ export function useResponseCache(options: UseResponseCacheParameter): Plugin {
     onRequestParse({ request }) {
       return {
         async onRequestParseDone({ params, setResult }) {
-          if (enabled(params, request)) {
+          if (enabled(request)) {
             const operationId = await buildResponseCacheKey({
               documentString: params.query!,
               variableValues: params.variables,
               operationName: params.operationName,
-              sessionId: await options.session(params, request),
+              sessionId: await options.session(request),
             })
             const cachedResponse = await cache.get(operationId)
             if (cachedResponse) {
@@ -79,3 +70,5 @@ export function useResponseCache(options: UseResponseCacheParameter): Plugin {
     },
   }
 }
+
+export { createInMemoryCache }