fix(vue-apollo): regression, respect omitOperationSuffix even with dedupeOperationSuffix enabled #5015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dupeOperationSuffix enabled
|
|
Could / Should I do the changeset stuff to get this merged asap? |
|
This is awesome, thank you @JoeSchr ! |
|
@dotansimha your project is awesome! changeset is updated |
dotansimha
added a commit
that referenced
this pull request
Nov 4, 2020
* Bump eslint-config-standard from 14.1.1 to 16.0.1 Bumps [eslint-config-standard](https://github.com/standard/eslint-config-standard) from 14.1.1 to 16.0.1. - [Release notes](https://github.com/standard/eslint-config-standard/releases) - [Changelog](https://github.com/standard/eslint-config-standard/blob/master/CHANGELOG.md) - [Commits](standard/eslint-config-standard@v14.1.1...v16.0.1) Signed-off-by: dependabot[bot] <support@github.com> * Improve typescript vue apollo plugin (#5007) * feat: support type imports Closes #5006 * fix: do not use undefined for variables generic and parameter Not using undefined for variables generic fixes the following issue: Type 'undefined' does not satisfy the constraint 'Record<string, any>' Not using undefined for variables parameter fixes the following issue: Argument of type 'undefined' is not assignable to parameter of type 'VariablesParameter<Exact<{ [key: string]: never; }>>' * feat: improve jsdoc formatting * Remove newlines before and after the first argument in the example code. * Add @param variables where applicable. * chore: add changeset * chore: update dev-test examples * fix(cli): resolve modules provided through the -r flags relative to the cwd (#4983) * fix(cli): require -r flags relative to the cwd * chore: disable eslint for import * fix(cli): resolve from folders correctly (#5032) * fix(cli): resolve from folders correctly * chore: changesets * modify apollo angular visitor to allow external operation definitions related to #4719 (#4765) * modify apollo angular visitor to allow external opration definitions * handle document * fix document * resolve unit test failures * add unit test * reset version * add changeset * add a warning for importOperationTypesFrom, update apollo-angular documentation * more warnings and tests to help get configuration correct * more eslint ignores * update documentation for external documentMode * more readme updates * more readme updates * fix(vue-apollo): regression, respect omitOperationSuffix even with dedupeOperationSuffix enabled (#5015) * fix(vue-apollo): regression, respect omitOperationSuffix even with dedupeOperationSuffix enabled * updated changeset * fix changeset Co-authored-by: Dotan Simha <dotansimha@gmail.com> * Bump graphql from 15.3.0 to 15.4.0 (#5008) * Bump graphql from 15.3.0 to 15.4.0 Bumps [graphql](https://github.com/graphql/graphql-js) from 15.3.0 to 15.4.0. - [Release notes](https://github.com/graphql/graphql-js/releases) - [Commits](graphql/graphql-js@v15.3.0...v15.4.0) Signed-off-by: dependabot[bot] <support@github.com> * update all snapshot fix for patches Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dotan Simha <dotansimha@gmail.com> * Bump eslint-config-standard from 14.1.1 to 16.0.1 Bumps [eslint-config-standard](https://github.com/standard/eslint-config-standard) from 14.1.1 to 16.0.1. - [Release notes](https://github.com/standard/eslint-config-standard/releases) - [Changelog](https://github.com/standard/eslint-config-standard/blob/master/CHANGELOG.md) - [Commits](standard/eslint-config-standard@v14.1.1...v16.0.1) Signed-off-by: dependabot[bot] <support@github.com> * fixes for lint issues Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Pascal Sthamer <sthamer.pascal@gmail.com> Co-authored-by: Kristoffer K <merceyz@users.noreply.github.com> Co-authored-by: Jeffrey Barrus <1044815+jbarrus@users.noreply.github.com> Co-authored-by: JoeSchr <JoeSchr@users.noreply.github.com> Co-authored-by: Dotan Simha <dotansimha@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #5014
omitOperationSuffix was not respected because of dedupeOperationSuffix
@packages/plugins/typescript/vue-apollo/src/visitor.ts:133