PLAT-6563: Fix S3 provisioning #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3 made some changes: https://aws.amazon.com/about-aws/whats-new/2022/12/amazon-s3-automatically-enable-block-public-access-disable-access-control-lists-buckets-april-2023/
Also see terraform notice: hashicorp/terraform-provider-aws#28353
Which now requires the example from the "with grants" section here: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_acl
Also, upgrade test was pulling some totally random, non-release tag. Not sure why, but I changed the tag-getting algorithm to be based on a reverse version sort. Long as the totally random tag that shouldn't be there isn't 9.99 or something, it should work going forward, and if it doesn't I'll at least understand why.
Note that I expect the upgrade test to fail anyway since the old version won't be able to provision the monitoring bucket.