Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typescript 5.5 parse for configDir #179

Merged
merged 10 commits into from
Jun 27, 2024

Conversation

lPernod-sorare
Copy link
Contributor

@lPernod-sorare lPernod-sorare commented Jun 26, 2024

This builds on #178 and fixes differences between parse and parseNative for configDir for typescript 5.5

@lPernod-sorare
Copy link
Contributor Author

Tests are broken on windows due to wrong implementation of #178, I'll fix there and rebase this on that

@dominikg
Copy link
Owner

thank you so much. You'll also have to run pnpm generate and pnpm changeset to update generated files and create a changeset.

If you are ok with it i'll push an extra testcase to ensure it doesn't regress and improve the ts 5.5 logic a bit.

@dominikg
Copy link
Owner

done, i did shorten the baseUrl implementation a bit and made it resilient for future tokens apart from configDir (although these need to be added to replaceTokens then).

@dominikg dominikg merged commit 1fc3257 into dominikg:main Jun 27, 2024
7 checks passed
@github-actions github-actions bot mentioned this pull request Jun 27, 2024
@dominikg
Copy link
Owner

Thanks a lot for catching this @lPernod-sorare ! it will be released with the next vite patch too.

@dominikg
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants