Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move from forward to back slashes in sql shell #8023

Closed
wants to merge 1 commit into from
Closed

move from forward to back slashes in sql shell #8023

wants to merge 1 commit into from

Conversation

macneale4
Copy link
Contributor

Decided to move from / to \ for sql shell commands to may the mysql client.

Work remaining:

  1. Forbid delimiter / with message: ERROR: DELIMITER cannot contain a backslash character. This requires a change in the ishell packages (which we forked).
  2. Dolt test to ensure (1).

@macneale4 macneale4 requested a review from nicktobey June 13, 2024 23:47
@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
20d4788 ok 5937457
version total_tests
20d4788 5937457
correctness_percentage
100.0

@macneale4 macneale4 closed this Jul 11, 2024
@macneale4 macneale4 deleted the macneale4/slash-back branch August 6, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicktobey nicktobey nicktobey approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@macneale4 @coffeegoddd @nicktobey