Improve CSP compliance for gfx and charting #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove usage of new Function()
dylans
approved these changes
Jan 3, 2020
dylans
pushed a commit
that referenced
this pull request
Feb 12, 2020
Remove usage of new Function() (cherry picked from commit 5491eff)
dylans
pushed a commit
that referenced
this pull request
Feb 12, 2020
Remove usage of new Function() (cherry picked from commit 5491eff)
dylans
pushed a commit
that referenced
this pull request
Feb 12, 2020
Remove usage of new Function() (cherry picked from commit 5491eff)
dylans
pushed a commit
that referenced
this pull request
Feb 12, 2020
Remove usage of new Function() (cherry picked from commit 5491eff)
dylans
pushed a commit
that referenced
this pull request
Feb 12, 2020
Remove usage of new Function() (cherry picked from commit 5491eff)
dylans
pushed a commit
that referenced
this pull request
Feb 12, 2020
Remove usage of new Function() (cherry picked from commit 5491eff)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #312
Remove usage of
new Function()This PR addresses the most common CSP issues with the charting code (and its gfx dependencies).
The
Chartwidget, when used with a declarative data provider, makes more extensive use ofevalanddojox/functional.lambdaand remains unaddressed in this PR. Using this widget this way is cumbersome and not recommended, and hopefully not being done in the wild.