Skip to content

Commit

Permalink
Excessive PHPDoc removed
Browse files Browse the repository at this point in the history
  • Loading branch information
SCIF committed Dec 29, 2017
1 parent 6333a15 commit 6147eb5
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 13 deletions.
7 changes: 1 addition & 6 deletions lib/Doctrine/DBAL/Platforms/AbstractPlatform.php
Original file line number Diff line number Diff line change
Expand Up @@ -3576,12 +3576,7 @@ public function getStringLiteralQuoteCharacter()
return "'";
}

/**
* @param string $table
*
* @return string
*/
protected function getDropPrimaryKeySQL(string $table): string
protected function getDropPrimaryKeySQL(string $table) : string
{
return 'ALTER TABLE ' . $table . ' DROP PRIMARY KEY';
}
Expand Down
5 changes: 1 addition & 4 deletions lib/Doctrine/DBAL/Platforms/PostgreSqlPlatform.php
Original file line number Diff line number Diff line change
Expand Up @@ -752,10 +752,7 @@ public function getDropForeignKeySQL($foreignKey, $table)
return $this->getDropConstraintSQL($foreignKey, $table);
}

/**
* {@inheritDoc}
*/
protected function getDropPrimaryKeySQL(string $table): string
protected function getDropPrimaryKeySQL(string $table) : string
{
return $this->getDropConstraintSQL("{$table}_pkey", $table);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,7 @@ public function autoIncrementTypeMigrations() : array
public function testAlterTableChangePrimaryKey() : void
{
$tableFrom = new Table('primary_key_userid');
$column = $tableFrom->addColumn('user_id', 'integer');
$column = $tableFrom->addColumn('user_id', 'integer');
$column->setAutoincrement(true);
$tableFrom->setPrimaryKey(['user_id']);
$this->_sm->dropAndCreateTable($tableFrom);
Expand All @@ -518,11 +518,11 @@ public function testAlterTableChangePrimaryKey() : void
self::assertTrue($tableFrom->getColumn('user_id')->getAutoincrement());

$tableTo = new Table('primary_key_id');
$column = $tableTo->addColumn('id', 'integer');
$column = $tableTo->addColumn('id', 'integer');
$column->setAutoincrement(true);
$tableTo->setPrimaryKey(['id']);

$c = new Comparator();
$c = new Comparator();
$diff = $c->diffTable($tableFrom, $tableTo);
self::assertInstanceOf(TableDiff::class, $diff, "There should be a difference and not false being returned from the table comparison");

Expand Down

0 comments on commit 6147eb5

Please sign in to comment.