DBAL-2925: added dropPrimaryKeySQL() method to platform. Used to fix …

…primary key management bug
doctrine · Dec 5, 2017 · 6333a15 · 6333a15
1 parent c7ca968
commit 6333a15
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 18 deletions.
diff --git a/lib/Doctrine/DBAL/Platforms/AbstractPlatform.php b/lib/Doctrine/DBAL/Platforms/AbstractPlatform.php
@@ -2065,6 +2065,11 @@ protected function getPreAlterTableIndexForeignKeySQL(TableDiff $diff)
             $sql[] = $this->getDropIndexSQL($index, $tableName);
         }
         foreach ($diff->changedIndexes as $index) {
+            if ($index->isPrimary()) {
+                $sql[] = $this->getDropPrimaryKeySQL($tableName);
+                continue;
+            }
+
             $sql[] = $this->getDropIndexSQL($index, $tableName);
         }
 
@@ -3570,4 +3575,14 @@ public function getStringLiteralQuoteCharacter()
     {
         return "'";
     }
+
+    /**
+     * @param string $table
+     *
+     * @return string
+     */
+    protected function getDropPrimaryKeySQL(string $table): string
+    {
+        return 'ALTER TABLE ' . $table . ' DROP PRIMARY KEY';
+    }
 }
diff --git a/lib/Doctrine/DBAL/Platforms/DrizzlePlatform.php b/lib/Doctrine/DBAL/Platforms/DrizzlePlatform.php
@@ -442,14 +442,6 @@ public function getDropIndexSQL($index, $table=null)
         return 'DROP INDEX ' . $indexName . ' ON ' . $table;
     }
 
-    /**
-     * {@inheritDoc}
-     */
-    protected function getDropPrimaryKeySQL($table)
-    {
-        return 'ALTER TABLE ' . $table . ' DROP PRIMARY KEY';
-    }
-
     /**
      * {@inheritDoc}
      */

diff --git a/lib/Doctrine/DBAL/Platforms/MySqlPlatform.php b/lib/Doctrine/DBAL/Platforms/MySqlPlatform.php
@@ -976,16 +976,6 @@ public function getDropIndexSQL($index, $table=null)
         return 'DROP INDEX ' . $indexName . ' ON ' . $table;
     }
 
-    /**
-     * @param string $table
-     *
-     * @return string
-     */
-    protected function getDropPrimaryKeySQL($table)
-    {
-        return 'ALTER TABLE ' . $table . ' DROP PRIMARY KEY';
-    }
-
     /**
      * {@inheritDoc}
      */

diff --git a/lib/Doctrine/DBAL/Platforms/PostgreSqlPlatform.php b/lib/Doctrine/DBAL/Platforms/PostgreSqlPlatform.php
@@ -752,6 +752,14 @@ public function getDropForeignKeySQL($foreignKey, $table)
         return $this->getDropConstraintSQL($foreignKey, $table);
     }
 
+    /**
+     * {@inheritDoc}
+     */
+    protected function getDropPrimaryKeySQL(string $table): string
+    {
+        return $this->getDropConstraintSQL("{$table}_pkey", $table);
+    }
+
     /**
      * {@inheritDoc}
      */