Enabling filter's default parameters in config files #159
Conversation
| @@ -60,7 +62,28 @@ private function enableFilters(EntityManager $entityManager) | |||
|
|
|||
| $filterCollection = $entityManager->getFilters(); | |||
| foreach ($this->enabledFilters as $filter) { | |||
| $filterCollection->enable($filter); | |||
| $oFilter = $filterCollection->enable($filter); | |||
There was a problem hiding this comment.
$filter is the filter name and $oFilter the filter object, is it a problem?
There was a problem hiding this comment.
we are not using the o*, s* convention to name variable starting with their type. So it is weird to have it used in a single place.
There was a problem hiding this comment.
ok, $filterObject sounds better?
|
your XML configuration will not work(try to put at lest 2 parameters) as it is not how prototype nodes should be represented. |
| /** | ||
| * Enable filters for an given entity manager | ||
| * | ||
| * @param EntityManager $entityManager |
|
This will fix previouly said bad things |
| @@ -60,7 +62,28 @@ private function enableFilters(EntityManager $entityManager) | |||
|
|
|||
| $filterCollection = $entityManager->getFilters(); | |||
| foreach ($this->enabledFilters as $filter) { | |||
| $filterCollection->enable($filter); | |||
| $filterObject = $filterCollection->enable($filter); | |||
| if( null !== $filterObject ) { | |||
There was a problem hiding this comment.
spaces should be around the braces, not inside them
| @@ -15,6 +15,7 @@ | |||
| namespace Doctrine\Bundle\DoctrineBundle; | |||
|
|
|||
| use Doctrine\ORM\EntityManager; | |||
| use Doctrine\ORM\Query\Filter\SQLFilter; | |||
|
+1 -- I need this functionality as well (ability to set parameters for filters within config). |
|
👍 we need this PR at work |
Enabling filter's default parameters in config files
|
Is there a way to use the service container to inject a value? Eg, I have a Site Context and I want to use the SiteId from that Entity. May relate to #134 |
Hi stof,
This update is comming from troubles we had to set a filter parameter at the application start, it enable default values in the config files without breaking older configs.
Jérémy