Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a prepare script. #1010

Merged
merged 2 commits into from
Jan 28, 2020
Merged

feat: Add a prepare script. #1010

merged 2 commits into from
Jan 28, 2020

Conversation

trusktr
Copy link
Member

@trusktr trusktr commented Jan 25, 2020

Summary

This makes it possible to depend on the docsify package using a git commit hash instead of a version number in package.json, and causes the lib folder to be built in those cases, otherwise consumers will try to import from a folder that doesn't exist.

For example, in package.json the following,

        "docsify": "docsifyjs/docsify#prepare-script",

tells npm to get docsify from the branch prepare-script from http://github.com/docsifyjs/docsify.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:


  • DO NOT include files inside lib directory.

This makes it possible to depend on the docsify package using a git commit hash instead of a version number in package.json, and causes the `lib` folder to be built in those cases, otherwise consumers will try to import from a folder that doesn't exist.
Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflicts.

@trusktr trusktr merged commit 07f6edc into develop Jan 28, 2020
@trusktr trusktr deleted the prepare-script branch January 28, 2020 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants