Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverpage link bug in >= 4.8.1 #677

Closed
dbanksdesign opened this issue Nov 1, 2018 · 1 comment
Closed

Coverpage link bug in >= 4.8.1 #677

dbanksdesign opened this issue Nov 1, 2018 · 1 comment

Comments

@dbanksdesign
Copy link

Here is my coverpage markdown file: https://github.com/amzn/style-dictionary/blob/master/docs/_coverpage.md

I noticed the github button styling broke in recent versions. I rolled back to 4.8.0 and they work again. Here is the issue that was filed on our repo: amzn/style-dictionary#185

It looks like the docsify parser was not adding data-button to the github link for some reason. And the stylesheet in <= 4.8.0 was not targeting data-button to style those buttons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants