Add try/catch w/ error message to plugin calls

docsifyjs · Feb 1, 2022 · 631e924 · 631e924
1 parent c49c39a
commit 631e924
Showing 1 changed file with 21 additions and 6 deletions.
diff --git a/src/core/init/lifecycle.js b/src/core/init/lifecycle.js
@@ -36,14 +36,29 @@ export function Lifecycle(Base) {
         if (index >= queue.length) {
           next(data);
         } else if (typeof hookFn === 'function') {
+          const errTitle = `Docsify plugin ${
+            hookFn.name ? '"' + hookFn.name + '"' : ''
+          } error (${hookName})`;
+
           if (hookFn.length === 2) {
-            hookFn(data, result => {
-              data = result;
-              step(index + 1);
-            });
+            try {
+              hookFn(data, result => {
+                data = result;
+              });
+            } catch (err) {
+              console.error(errTitle, err);
+            }
+            step(index + 1);
           } else {
-            const result = hookFn(data);
-            data = result === undefined ? data : result;
+            let result;
+
+            try {
+              result = hookFn(data);
+            } catch (err) {
+              console.error(errTitle, err);
+            }
+
+            data = result || data;
             step(index + 1);
           }
         } else {