Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENGDOCS-2140 #20300

Merged
merged 4 commits into from
Jul 8, 2024
Merged

ENGDOCS-2140 #20300

merged 4 commits into from
Jul 8, 2024

Conversation

aevesdocker
Copy link
Contributor

@aevesdocker aevesdocker commented Jun 26, 2024 •
edited
Loading

Description

Learning path update https://docker.atlassian.net/browse/ENGDOCS-2140

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added the area/compose Relates to docker-compose.yml spec or docker-compose binary label Jun 26, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 26, 2024 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 9ec8e50
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/668b9f5cb9b757000848b208
😎 Deploy Preview https://deploy-preview-20300--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aevesdocker aevesdocker requested a review from glours July 1, 2024 09:36
glours
glours approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

content/compose/compose-application-model.md Outdated Show resolved Hide resolved
@aevesdocker aevesdocker marked this pull request as ready for review July 4, 2024 09:36
@aevesdocker aevesdocker requested a review from a team July 4, 2024 09:39
@aevesdocker @dvdksn
Update content/compose/compose-application-model.md
ae3ff52 
Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@aevesdocker aevesdocker requested a review from dvdksn July 5, 2024 07:55
@dvdksn
Copy link
Contributor

dvdksn commented Jul 8, 2024

There's a broken link https://github.com/docker/docs/actions/runs/9804995839/job/27073786983?pr=20300#step:4:465

dvdksn
dvdksn approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failure unrelated (flaky)

@aevesdocker aevesdocker merged commit 51e5271 into docker:main Jul 8, 2024
11 of 12 checks passed
elegantcoder pushed a commit to elegantcoder/docs that referenced this pull request Aug 28, 2024
@aevesdocker @dvdksn @elegantcoder
ENGDOCS-2140 (docker#20300)
dc97ac4 
* ENGDOCS-2140

* SME review

* Update content/compose/compose-application-model.md

Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>

* Apply suggestions from code review

---------

Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glours glours glours approved these changes

@dvdksn dvdksn dvdksn approved these changes

Assignees
No one assigned
Labels
area/compose Relates to docker-compose.yml spec or docker-compose binary status/review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aevesdocker @dvdksn @glours