Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

desktop: update volume export #20295

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

desktop: update volume export #20295

wants to merge 3 commits into from

Conversation

craig-osterhout
Copy link
Contributor

@craig-osterhout craig-osterhout commented Jun 25, 2024 •
edited
Loading

Description

Preview: https://deploy-preview-20295--docsdocker.netlify.app/desktop/use-desktop/volumes/

Updated docs based on new Volumes UI.
Added scheduled volume exports, and cloud export.
Added redirects for in-product links.

Related issues or tickets

ENGDOCS-2121

Reviews

  • Technical review
  • Editorial review
  • Product review

@craig-osterhout
add volume export m2
5d841ce 
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
@craig-osterhout craig-osterhout added this to the 4.32 milestone Jun 25, 2024
@craig-osterhout craig-osterhout requested review from smnovick and a team June 25, 2024 18:07
@github-actions github-actions bot added the area/desktop Issue affects a desktop edition of Docker. E.g docker for mac label Jun 25, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 25, 2024 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit c51319c
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/667c36ff6ad4e70008c66aab
😎 Deploy Preview https://deploy-preview-20295--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@craig-osterhout
fix ol
24b8357 
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
aevesdocker
aevesdocker previously approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Two non-blocking comments.
Also, I don't see this in the release notes, perhaps @smnovick could add a suggestion for the entry? #20284

content/desktop/use-desktop/volumes.md Outdated Show resolved Hide resolved
content/desktop/use-desktop/volumes.md Outdated Show resolved Hide resolved
@craig-osterhout
Copy link
Contributor Author

craig-osterhout commented Jun 26, 2024 •
edited
Loading

Also, I don't see this in the release notes

@aevesdocker, yes, I think it was a late addition. https://www.notion.so/dockerinc/Final-release-highlights-5ac441403fc44f0eae9763e2eef9a8f6

@craig-osterhout
rearrange sections
c51319c 
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvdksn dvdksn dvdksn left review comments

@smnovick smnovick smnovick approved these changes

@aevesdocker aevesdocker aevesdocker approved these changes

Assignees
No one assigned
Labels
area/desktop Issue affects a desktop edition of Docker. E.g docker for mac
Projects
None yet
Milestone
4.32
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@craig-osterhout @smnovick @dvdksn @aevesdocker