Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.03 backport] vendor buildkit to f238f1e, bump google.golang.org/grpc v1.20.1 #1884

Merged
merged 2 commits into from
May 14, 2019

Conversation

thaJeztah
Copy link
Member

backport of;

full diff: grpc/grpc-go@v1.12.2...v1.20.1

includes grpc/grpc-go#2695 transport: do not close channel that can lead to panic
fixes moby/moby#39053

Tibor Vass and others added 2 commits May 13, 2019 18:43
Signed-off-by: Tibor Vass <tibor@docker.com>
(cherry picked from commit 529ef6e)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
full diff: grpc/grpc-go@v1.12.2...v1.20.1

includes  grpc/grpc-go#2695 transport: do not close channel that can lead to panic
addresses moby/moby#39053

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 93d76c5)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-io
Copy link

Codecov Report

Merging #1884 into 19.03 will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##            19.03    #1884   +/-   ##
=======================================
  Coverage   56.73%   56.73%           
=======================================
  Files         309      309           
  Lines       21666    21666           
=======================================
  Hits        12292    12292           
  Misses       8477     8477           
  Partials      897      897

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #1884 into 19.03 will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##            19.03    #1884   +/-   ##
=======================================
  Coverage   56.73%   56.73%           
=======================================
  Files         309      309           
  Lines       21666    21666           
=======================================
  Hits        12292    12292           
  Misses       8477     8477           
  Partials      897      897

@tiborvass tiborvass merged commit 8aebc31 into docker:19.03 May 14, 2019
@thaJeztah thaJeztah deleted the 19.03_bump_buildkit_grpc branch May 14, 2019 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants