-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to rails 7 #377
Open
sitarane
wants to merge
40
commits into
docker:master
Choose a base branch
from
sitarane:update-to-rails-7
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update to rails 7 #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sitarane
commented
Aug 3, 2023
- Update both ruby and rails to current versions
- Add named volumes to compose file
- Add an .env file
- Add a separate container for the test environment
- Add an email client container for apps that send email (plus config steps)
- Add a web browser container for system tests (plus config steps)
- Replace the old rails5 screenshot with the current one
Update Dockerfile Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Comment out the precompile-asset line in Dockerfile. Only used in prod. Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Change rails version to 7 Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Rename myapp > app in entryfile Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Update docker-compose Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Add .env file Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Add some structure to the document Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Set up the database connection in rails. Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Create the database Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Signed-off-by: sitarane <julien@larevolution.re>
Comment out the compose file section about the debugger. Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Add some useful commands Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Edit "up" command so it doesn't start unnecessary services. Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
User needs to uncomment the mail client and the test browser if they need it. Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
Signed-off-by: Julien Boyer <julien@larevolution.re> Signed-off-by: sitarane <julien@larevolution.re>
sitarane
force-pushed
the
update-to-rails-7
branch
from
August 3, 2023 19:10
1614bad
to
beec100
Compare
stewartmbofana
approved these changes
Oct 1, 2023
This was referenced Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.