Use multithreaded mode for flask. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multi-threaded mode should be used here, even for this very simple app. Otherwise, if someone tests this container on e.g. AWS ECS or AWS EB with an ELB, they will see the ELB health check keep-alive request consume the only request thread, which will cause the container to be killed repeatedly and the user to be deeply confused. I lost many hours trying to debug this, figuring it was a problem with how I had ECS/EB set up, but it was actually a nit in this example flask app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-threaded mode should be used here, even for this very simple app.
Otherwise, if someone tests this container on e.g. AWS ECS or AWS EB
with an ELB, they will see the ELB health check keep-alive request
consume the only request thread, which will cause the container to be
killed repeatedly and the user to be deeply confused.
I lost many hours trying to debug this, figuring it was a problem with
how I had ECS/EB set up, but it was actually a nit in this example app.