Starts v0.10.0 #37
Merged
Starts v0.10.0 #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Command and Response objects should have names that follow the same form. I've arbitrarily decided on VerbNoun. Since this is an API-breaking change and we're in pre-1.0.0, I've bumped the minor version from 9 to 10.
This moves the Response objects into the same package as their associated commands, since they're so tightly coupled.
This renames the command class and related methods to match the method name in the Docker Remote API. https://docs.docker.com/reference/api/docker_remote_api_v1.13/#22-images
This changes the CopyFileFromContainer's impl method to not call toString on the copyConfig that it uses in the POST body, instead relying on the default JSON serializer and marked fields. This will allow us to use a reflection-based toString. This commit also creates a test around the use of the CopyFileFromContainer command.
This cuts down on some of the boilerplate code. Since we're already bringing Apache Commons Lang, we might as well use it.
Replacing more boilder-plate code with something that'll be easier to maintain.
This is the first step toward simplifying or getting rid of the CommitConfig object.
If you don't have any of your own containers, the InfoCmd integration test can fail. This commit makes sure there's at least one container present.
This effectively hides the config objects from the public API, as I expect they'll either go away or get simplified.
The HostConfig is already a sub-class of the InspectContainerResponse object.
Having a slightly less generic class name is probably a good thing...
DockerClient is now an immutable class. The only way to set credentials now is at construction of the DockerClient, using the DockerClientConfig object.
Conflicts: src/main/java/com/github/dockerjava/client/command/CreateContainerCmd.java
|
@mfulgo Thanks Matthew, great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.