Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use Nova Helper Function for Resource URL Generation #40

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

KasparRosin
Copy link
Contributor

Overview

This pull request addresses the issue where resource navigation (create, edit, view) fails with a 404 error when Laravel Nova is configured to reside on the root domain instead of using the /nova slug. The root cause of the problem was identified as the hardcoded usage of /nova in the application code, specifically in the resource URL generation logic.

Changes

  • Modified the resource URL generation to use Nova's helper function for creating resource URLs. This approach dynamically respects the Nova path configuration, making the functionality compatible with Nova installations at any path.

closes: #39

@dnwjn
Copy link
Owner

dnwjn commented Mar 20, 2024

Hi @KasparRosin! Thank you for your extensive and detailed PR and issue. Very well spotted and you I think your fix is great, so I'll merge and release it right away!

@dnwjn dnwjn merged commit a6b99d8 into dnwjn:main Mar 20, 2024
1 of 2 checks passed
@KasparRosin KasparRosin deleted the bug/issue-39 branch March 21, 2024 08:57
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource Navigation Fails with 404 Error When Nova Configured at Root Domain
2 participants