Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[WIP][BUGFIX] Fix a data sampling bug in BERT pre-training #977

Merged
merged 1 commit into from
Oct 21, 2019

Conversation

eric-haibin-lin
Copy link
Member

Description

@rich-junwang

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

cc @dmlc/gluon-nlp-team

@eric-haibin-lin eric-haibin-lin requested a review from a team as a code owner October 19, 2019 18:43
@codecov
Copy link

codecov bot commented Oct 19, 2019

Codecov Report

Merging #977 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #977   +/-   ##
=======================================
  Coverage   89.83%   89.83%           
=======================================
  Files          67       67           
  Lines        6364     6364           
=======================================
  Hits         5717     5717           
  Misses        647      647

@mli
Copy link
Member

mli commented Oct 19, 2019

Job PR-977/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-977/1/index.html

@szhengac szhengac merged commit 89b41bd into dmlc:master Oct 21, 2019
@eric-haibin-lin eric-haibin-lin deleted the data-fix branch February 2, 2020 06:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants