Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Update numba dependency in setup.py #941

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Conversation

leezu
Copy link
Contributor

@leezu leezu commented Sep 24, 2019

numba<=0.45.1 is incompatible with numpy>=1.17

cc @dmlc/gluon-nlp-team

numba<=0.45.1 is incompatible with numpy>=1.17
@leezu leezu requested a review from a team as a code owner September 24, 2019 10:17
@mli
Copy link
Member

mli commented Sep 24, 2019

Job PR-941/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-941/1/index.html

@codecov
Copy link

codecov bot commented Sep 24, 2019

Codecov Report

Merging #941 into master will increase coverage by 0.54%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #941      +/-   ##
==========================================
+ Coverage   90.12%   90.67%   +0.54%     
==========================================
  Files          67       67              
  Lines        6389     6389              
==========================================
+ Hits         5758     5793      +35     
+ Misses        631      596      -35
Impacted Files Coverage Δ
src/gluonnlp/data/word_embedding_evaluation.py 96.96% <0%> (+0.75%) ⬆️
src/gluonnlp/data/dataset.py 99.2% <0%> (+1.58%) ⬆️
src/gluonnlp/data/batchify/batchify.py 96.59% <0%> (+3.4%) ⬆️
src/gluonnlp/data/transforms.py 81.59% <0%> (+4.59%) ⬆️
src/gluonnlp/data/corpora/wikitext.py 100% <0%> (+5.17%) ⬆️
src/gluonnlp/model/parameter.py 100% <0%> (+8%) ⬆️

@szha szha merged commit cfb02a9 into dmlc:master Sep 24, 2019
@leezu leezu deleted the updatenumbadep branch September 25, 2019 09:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants