Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[REFACTOR] Drop unused compatibility helpers and fix doc #928

Merged
merged 6 commits into from
Sep 16, 2019
Merged

[REFACTOR] Drop unused compatibility helpers and fix doc #928

merged 6 commits into from
Sep 16, 2019

Conversation

leezu
Copy link
Contributor

@leezu leezu commented Sep 15, 2019

Description

Clean unused unused Python 2 compatibility stuff from codebase and update Python 2 respective docstrings.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Drop unused Python 2 compatibility helpers and fix doc

@leezu leezu requested a review from a team September 15, 2019 16:10
@codecov
Copy link

codecov bot commented Sep 15, 2019 •
edited
Loading

Codecov Report

Merging #928 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #928      +/-   ##
==========================================
- Coverage   89.71%   89.64%   -0.07%     
==========================================
  Files          66       66              
  Lines        6406     6347      -59     
==========================================
- Hits         5747     5690      -57     
+ Misses        659      657       -2
Impacted Files Coverage Δ
src/gluonnlp/model/highway.py 100% <ø> (ø) ⬆️
src/gluonnlp/model/bilm_encoder.py 100% <ø> (ø) ⬆️
src/gluonnlp/utils/parameter.py 81.35% <ø> (ø) ⬆️
src/gluonnlp/embedding/evaluation.py 95.79% <ø> (ø) ⬆️
src/gluonnlp/optimizer/__init__.py 100% <ø> (ø) ⬆️
src/gluonnlp/data/word_embedding_evaluation.py 96.96% <ø> (ø) ⬆️
src/gluonnlp/model/translation.py 71.42% <ø> (ø) ⬆️
src/gluonnlp/loss/__init__.py 100% <ø> (ø) ⬆️
src/gluonnlp/optimizer/bert_adam.py 86.27% <ø> (ø) ⬆️
src/gluonnlp/model/transformer.py 91.2% <ø> (ø) ⬆️
... and 58 more

@mli
Copy link
Member

mli commented Sep 15, 2019

Job PR-928/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-928/1/index.html

@mli
Copy link
Member

mli commented Sep 15, 2019

Job PR-928/2 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-928/2/index.html

@mli
Copy link
Member

mli commented Sep 15, 2019

Job PR-928/3 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-928/3/index.html

@leezu leezu changed the title [REFACTOR] Drop unused Python 2 compatibility helpers and fix doc [REFACTOR] Drop unused compatibility helpers and fix doc Sep 15, 2019
@leezu
Drop unneeded __future__ imports
4b5cdbe
@leezu
Delete _convert_to_unicode helper
c53dced 
The helper is a no-op (in Py3) in all the current use-cases. However, it is
dangerous at it silently converts bytes to utf-8, ignoring all errors. It thus
shouldn't be used and should be removed.
@mli
Copy link
Member

mli commented Sep 15, 2019

Job PR-928/4 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-928/4/index.html

@mli
Copy link
Member

mli commented Sep 15, 2019

Job PR-928/9 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-928/9/index.html

@leezu leezu merged commit 9863d8b into dmlc:master Sep 16, 2019
@leezu leezu deleted the droppy2stuff branch September 16, 2019 12:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eric-haibin-lin eric-haibin-lin eric-haibin-lin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leezu @mli @eric-haibin-lin