Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[BUGFIX] fix a SQUAD2.0 bug #907

Merged
merged 1 commit into from
Sep 2, 2019
Merged

Conversation

eric-haibin-lin
Copy link
Member

@eric-haibin-lin eric-haibin-lin commented Aug 28, 2019

Description

(Brief description on what this PR is about)

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@codecov
Copy link

codecov bot commented Aug 28, 2019

Codecov Report

❗ No coverage uploaded for pull request head (sq@508e60e). Click here to learn what that means.
The diff coverage is n/a.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 28, 2019

Codecov Report

❗ No coverage uploaded for pull request head (sq@508e60e). Click here to learn what that means.
The diff coverage is n/a.

@mli
Copy link
Member

mli commented Aug 28, 2019

Job PR-907/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-907/1/index.html

@szha
Copy link
Member

szha commented Sep 2, 2019

Is this still WIP?

@eric-haibin-lin eric-haibin-lin changed the title [BUGFIX] [WIP] fix SQUAD2.0 bug [BUGFIX] fix a SQUAD2.0 bug Sep 2, 2019
@mli
Copy link
Member

mli commented Sep 2, 2019

Job PR-907/11 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-907/11/index.html

@eric-haibin-lin eric-haibin-lin merged commit 6ba10e4 into dmlc:master Sep 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants