Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[DOC] Fix code comment #810

Merged
merged 1 commit into from
Jul 3, 2019
Merged

[DOC] Fix code comment #810

merged 1 commit into from
Jul 3, 2019

Conversation

rongruosong
Copy link
Contributor

@rongruosong rongruosong commented Jul 3, 2019 •
edited by eric-haibin-lin
Loading

Description

fix code comment

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@rongruosong rongruosong requested a review from szha as a code owner July 3, 2019 12:08
@codecov
Copy link

codecov bot commented Jul 3, 2019

Codecov Report

❗ No coverage uploaded for pull request head (master@db84060). Click here to learn what that means.
The diff coverage is n/a.

1 similar comment
@codecov
Copy link

codecov bot commented Jul 3, 2019

Codecov Report

❗ No coverage uploaded for pull request head (master@db84060). Click here to learn what that means.
The diff coverage is n/a.

@mli
Copy link
Member

mli commented Jul 3, 2019

Job PR-810/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-810/1/index.html

@eric-haibin-lin eric-haibin-lin changed the title fix code comment [DOC] Fix code comment Jul 3, 2019
@eric-haibin-lin eric-haibin-lin merged commit 640832d into dmlc:master Jul 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@szha szha szha approved these changes

@eric-haibin-lin eric-haibin-lin eric-haibin-lin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rongruosong @mli @szha @eric-haibin-lin