Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Fix badge icon #800

Merged
merged 3 commits into from
Jun 29, 2019
Merged

Fix badge icon #800

merged 3 commits into from
Jun 29, 2019

Conversation

hetong007
Copy link
Member

Description

Fix broken badge icon in readme file.

Checklist

Essentials

  • Changes are complete (i.e. I finished coding on this PR)

Reference: dmlc/gluon-cv#837

@hetong007 hetong007 requested a review from szha as a code owner June 27, 2019 21:55
@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

❗ No coverage uploaded for pull request head (fix_ci_badge@01d09e8). Click here to learn what that means.
The diff coverage is n/a.

@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@95db4bb). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #800   +/-   ##
=========================================
  Coverage          ?   90.12%           
=========================================
  Files             ?       66           
  Lines             ?     6378           
  Branches          ?        0           
=========================================
  Hits              ?     5748           
  Misses            ?      630           
  Partials          ?        0

@mli
Copy link
Member

mli commented Jun 27, 2019

Job PR-800/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-800/1/index.html

@szha szha requested a review from leezu June 27, 2019 23:01
@mli
Copy link
Member

mli commented Jun 28, 2019

Job PR-800/2 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-800/2/index.html

Copy link
Contributor

@leezu leezu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why http://ci.mxnet.io/buildStatus/icon?job=gluon-nlp%2Fmaster says "build not run"?

@hetong007
Copy link
Member Author

@szha do you have better understanding in it?
In principal this badge shows the status for master branch building status, and for gluoncv it works well. Could you make sure that the master branch has been built?

@szha
Copy link
Member

szha commented Jun 28, 2019

@leezu @hetong007 after breaking the single pipeline into multiple pipelines, the job that the icon linked to is no longer used.

@mli
Copy link
Member

mli commented Jun 28, 2019

Job PR-800/3 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-800/3/index.html

@hetong007
Copy link
Member Author

@szha would you please restart the flaky tests?

@szha szha merged commit b496b8f into dmlc:master Jun 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants