Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[Enhancement] Fix dtype conversion, add sentencepiece support for SQuAD #766

Merged
merged 5 commits into from
Jun 18, 2019

Conversation

eric-haibin-lin
Copy link
Member

@eric-haibin-lin eric-haibin-lin commented Jun 12, 2019

Description

As title. @davisliang @fierceX please help review.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@codecov
Copy link

codecov bot commented Jun 12, 2019

Codecov Report

Merging #766 into master will decrease coverage by 0.04%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #766      +/-   ##
==========================================
- Coverage   90.77%   90.73%   -0.05%     
==========================================
  Files          64       64              
  Lines        6116     6121       +5     
==========================================
+ Hits         5552     5554       +2     
- Misses        564      567       +3
Impacted Files Coverage Δ
src/gluonnlp/utils/parameter.py 81.35% <50%> (-3.83%) ⬇️

@mli
Copy link
Member

mli commented Jun 12, 2019

Job PR-766/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-766/1/index.html

@mli
Copy link
Member

mli commented Jun 12, 2019

Job PR-766/2 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-766/2/index.html

@eric-haibin-lin eric-haibin-lin changed the title [Enhancement] Fix dtype conversion, add sentencepiece support for SQuAD [WIP][Enhancement] Fix dtype conversion, add sentencepiece support for SQuAD Jun 12, 2019
@mli
Copy link
Member

mli commented Jun 13, 2019

Job PR-766/3 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-766/3/index.html

@mli
Copy link
Member

mli commented Jun 13, 2019

Job PR-766/4 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-766/4/index.html

@eric-haibin-lin eric-haibin-lin changed the title [WIP][Enhancement] Fix dtype conversion, add sentencepiece support for SQuAD [Enhancement] Fix dtype conversion, add sentencepiece support for SQuAD Jun 18, 2019
@eric-haibin-lin eric-haibin-lin merged commit b61667d into dmlc:master Jun 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants