Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[DOC] Update textCNN results #737

Merged
merged 4 commits into from
Jun 3, 2019
Merged

[DOC] Update textCNN results #737

merged 4 commits into from
Jun 3, 2019

Conversation

xiaotinghe
Copy link
Member

Description

Update textCNN results

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Update textCNN results

Comments

@xiaotinghe xiaotinghe requested a review from szha as a code owner May 30, 2019 14:34
@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

Merging #737 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #737      +/-   ##
==========================================
+ Coverage   90.56%   90.58%   +0.02%     
==========================================
  Files          65       65              
  Lines        6071     6076       +5     
==========================================
+ Hits         5498     5504       +6     
+ Misses        573      572       -1
Impacted Files Coverage Δ
src/gluonnlp/data/corpora/google_billion_word.py 66.66% <0%> (-8.34%) ⬇️
src/gluonnlp/data/utils.py 76.25% <0%> (-2.1%) ⬇️
src/gluonnlp/vocab/vocab.py 97.94% <0%> (ø) ⬆️
src/gluonnlp/data/dataloader.py 88.79% <0%> (+5.17%) ⬆️
...p/data/corpora/large_text_compression_benchmark.py 89.28% <0%> (+8.92%) ⬆️

Copy link
Member

@eric-haibin-lin eric-haibin-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you fix lint?
/var/lib/jenkins/workspace/workspace/gluon-nlp-gpu-py3/docs/model_zoo/sentiment_analysis/index.rst:77:Blank line required after table.

@xiaotinghe
Copy link
Member Author

done

@mli
Copy link
Member

mli commented May 31, 2019

Job PR-737/2 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-737/2/index.html

@mli
Copy link
Member

mli commented Jun 3, 2019

Job PR-737/3 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-737/3/index.html

@mli
Copy link
Member

mli commented Jun 3, 2019

Job PR-737/4 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-737/4/index.html

@yzh119
Copy link
Member

yzh119 commented Jun 3, 2019

Hi, I noticed a performance gap between previous results: https://github.com/dmlc/gluon-nlp/blob/5e1e7155517d0bed020b76357ff1bd77cedaf45d/scripts/sentiment_analysis/index.rst and results in this pr.
Could I know what causes the difference?

@astonzhang
Copy link
Member

Hi, I noticed a performance gap between previous results: https://github.com/dmlc/gluon-nlp/blob/5e1e7155517d0bed020b76357ff1bd77cedaf45d/scripts/sentiment_analysis/index.rst and results in this pr.
Could I know what causes the difference?

We updated the data sets.

@astonzhang astonzhang merged commit bef24e7 into dmlc:master Jun 3, 2019
paperplanet pushed a commit to paperplanet/gluon-nlp that referenced this pull request Jun 9, 2019
* fix doc

* fix doc

* fix doc

* fix doc
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants