Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[Dataset] Fix CoLA dataset index and add Glue dataset API #682

Merged
merged 9 commits into from
May 2, 2019

Conversation

eric-haibin-lin
Copy link
Member

@eric-haibin-lin eric-haibin-lin commented Apr 27, 2019

Description

Added Glue datasets to the dataset API. Will refactor scripts/bert/dataset.py in a followup PR.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

src/gluonnlp/data/glue.py Outdated Show resolved Hide resolved
@eric-haibin-lin eric-haibin-lin changed the title [WIP] Fix CoLA dataset index and add Glue dataset API [Dataset] Fix CoLA dataset index and add Glue dataset API Apr 28, 2019
@codecov
Copy link

codecov bot commented Apr 30, 2019

Codecov Report

Merging #682 into master will increase coverage by 0.9%.
The diff coverage is 98.91%.

@@            Coverage Diff            @@
##           master     #682     +/-   ##
=========================================
+ Coverage   64.48%   65.38%   +0.9%     
=========================================
  Files         154      143     -11     
  Lines       14385    13269   -1116     
=========================================
- Hits         9276     8676    -600     
+ Misses       5109     4593    -516
Flag Coverage Δ
#PR435 ?
#PR466 ?
#PR588 ?
#PR612 ?
#PR648 ?
#PR663 ?
#PR669 ?
#PR672 ?
#PR678 ?
#PR682 65.38% <98.91%> (?)
#master ?
#notserial 41.71% <28.64%> (+2.89%) ⬆️
#py2 65.21% <98.91%> (-0.04%) ⬇️
#py3 65.63% <28.64%> (+1.27%) ⬆️
#serial 51.4% <98.91%> (+0.21%) ⬆️

@codecov
Copy link

codecov bot commented Apr 30, 2019

Codecov Report

Merging #682 into master will increase coverage by 0.47%.
The diff coverage is 98.91%.

@@            Coverage Diff             @@
##           master     #682      +/-   ##
==========================================
+ Coverage   64.98%   65.45%   +0.47%     
==========================================
  Files         143      144       +1     
  Lines       13127    13300     +173     
==========================================
+ Hits         8530     8706     +176     
+ Misses       4597     4594       -3
Flag Coverage Δ
#PR682 65.45% <98.91%> (?)
#master ?
#notserial 41.71% <28.64%> (+0.13%) ⬆️
#py2 65.21% <98.91%> (-23.89%) ⬇️
#py3 65.34% <98.91%> (+0.44%) ⬆️
#serial 51.61% <98.91%> (+0.44%) ⬆️

@mli
Copy link
Member

mli commented May 1, 2019

Job PR-682/13 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-682/13/index.html

@eric-haibin-lin
Copy link
Member Author

@Gpwner could you help review the CoLADataset class?

Copy link
Contributor

@vanewu vanewu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Every data is correct. When checking this, I found that the field of the test data in the previous COLADataset was incorrect. https://github.com/dmlc/gluon-nlp/blob/master/scripts/bert/dataset.py#L300.

@szha szha merged commit 9e082b4 into dmlc:master May 2, 2019
gigasquid pushed a commit to gigasquid/gluon-nlp that referenced this pull request May 6, 2019
* add test

* add the rest

* fix doc and link

* fix import

* fix lint

* update test

* Fix py3 compatibility
@eric-haibin-lin eric-haibin-lin deleted the cola branch May 9, 2019 04:54
astonzhang pushed a commit that referenced this pull request May 10, 2019
* add test

* add the rest

* fix doc and link

* fix import

* fix lint

* update test

* Fix py3 compatibility
paperplanet pushed a commit to paperplanet/gluon-nlp that referenced this pull request Jun 9, 2019
* add test

* add the rest

* fix doc and link

* fix import

* fix lint

* update test

* Fix py3 compatibility
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants