This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 538
[Dataset] Fix CoLA dataset index and add Glue dataset API #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanewu
reviewed
Apr 27, 2019
eric-haibin-lin
changed the title
[WIP] Fix CoLA dataset index and add Glue dataset API
[Dataset] Fix CoLA dataset index and add Glue dataset API
Apr 28, 2019
Codecov Report
@@ Coverage Diff @@
## master #682 +/- ##
=========================================
+ Coverage 64.48% 65.38% +0.9%
=========================================
Files 154 143 -11
Lines 14385 13269 -1116
=========================================
- Hits 9276 8676 -600
+ Misses 5109 4593 -516
|
Codecov Report
@@ Coverage Diff @@
## master #682 +/- ##
==========================================
+ Coverage 64.98% 65.45% +0.47%
==========================================
Files 143 144 +1
Lines 13127 13300 +173
==========================================
+ Hits 8530 8706 +176
+ Misses 4597 4594 -3
|
Job PR-682/13 is complete. |
@Gpwner could you help review the CoLADataset class? |
szha
approved these changes
May 1, 2019
szha
reviewed
May 1, 2019
vanewu
approved these changes
May 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Every data is correct. When checking this, I found that the field of the test data in the previous COLADataset was incorrect. https://github.com/dmlc/gluon-nlp/blob/master/scripts/bert/dataset.py#L300.
6 tasks
gigasquid
pushed a commit
to gigasquid/gluon-nlp
that referenced
this pull request
May 6, 2019
* add test * add the rest * fix doc and link * fix import * fix lint * update test * Fix py3 compatibility
astonzhang
pushed a commit
that referenced
this pull request
May 10, 2019
* add test * add the rest * fix doc and link * fix import * fix lint * update test * Fix py3 compatibility
paperplanet
pushed a commit
to paperplanet/gluon-nlp
that referenced
this pull request
Jun 9, 2019
* add test * add the rest * fix doc and link * fix import * fix lint * update test * Fix py3 compatibility
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Glue datasets to the dataset API. Will refactor scripts/bert/dataset.py in a followup PR.
Checklist
Essentials
Changes
Comments