Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[Parallel] SQuAD multi-GPU script #1079

Merged
merged 26 commits into from
Feb 1, 2020
Merged

[Parallel] SQuAD multi-GPU script #1079

merged 26 commits into from
Feb 1, 2020

Conversation

eric-haibin-lin
Copy link
Member

@eric-haibin-lin eric-haibin-lin commented Dec 23, 2019

Description

@szhengac

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@eric-haibin-lin eric-haibin-lin requested a review from a team as a code owner December 23, 2019 05:36
@codecov
Copy link

codecov bot commented Dec 23, 2019

Codecov Report

Merging #1079 into master will increase coverage by 0.04%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1079      +/-   ##
==========================================
+ Coverage   88.25%   88.29%   +0.04%     
==========================================
  Files          67       67              
  Lines        6291     6316      +25     
==========================================
+ Hits         5552     5577      +25     
  Misses        739      739
Impacted Files Coverage Δ
src/gluonnlp/model/bert.py 92.65% <95.23%> (+0.47%) ⬆️
src/gluonnlp/data/utils.py 85.79% <0%> (-0.6%) ⬇️
src/gluonnlp/model/transformer.py 91.66% <0%> (+0.32%) ⬆️
src/gluonnlp/data/transforms.py 83.05% <0%> (+0.32%) ⬆️
src/gluonnlp/model/attention_cell.py 92.17% <0%> (+0.55%) ⬆️

@szhengac
Copy link
Member

szhengac commented Dec 23, 2019 via email

@leezu
Copy link
Contributor

leezu commented Dec 24, 2019

Nightly builds are fixed and work with horovod since 2 weeks. See apache/mxnet#16193

But note that nightly builds are not published on pypi anymore.

@eric-haibin-lin
Copy link
Member Author

@szha @ptrendx mxnet pypi limit was increased. Will mxnet 1.6 stable release include the symbols needed by horovod?

@szha
Copy link
Member

szha commented Dec 26, 2019

@eric-haibin-lin yes

@eric-haibin-lin eric-haibin-lin added the release focus Progress focus for release label Jan 15, 2020
@mli
Copy link
Member

mli commented Jan 28, 2020

Job PR-1079/16 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1079/16/index.html

@mli
Copy link
Member

mli commented Jan 28, 2020

Job PR-1079/17 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1079/17/index.html

@mli
Copy link
Member

mli commented Jan 29, 2020

Job PR-1079/18 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1079/18/index.html

@mli
Copy link
Member

mli commented Jan 29, 2020

Job PR-1079/19 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1079/19/index.html

@eric-haibin-lin eric-haibin-lin changed the title [Parallel] SQuAD multi-GPU script [WIP] [Parallel] SQuAD multi-GPU script Jan 31, 2020
@mli
Copy link
Member

mli commented Jan 31, 2020

Job PR-1079/20 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1079/20/index.html

@eric-haibin-lin eric-haibin-lin changed the title [WIP] [Parallel] SQuAD multi-GPU script [Parallel] SQuAD multi-GPU script Jan 31, 2020
@mli
Copy link
Member

mli commented Jan 31, 2020

Job PR-1079/21 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1079/21/index.html

@leezu leezu merged commit 417c045 into dmlc:master Feb 1, 2020
@eric-haibin-lin eric-haibin-lin deleted the squad branch February 2, 2020 06:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release focus Progress focus for release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants