Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[BUGFIX] Fix dtype mismatch for NaN check #1037

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Conversation

eric-haibin-lin
Copy link
Member

Description

Fixes #1034

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

cc @dmlc/gluon-nlp-team

@eric-haibin-lin eric-haibin-lin requested a review from a team as a code owner December 5, 2019 03:55
@codecov
Copy link

codecov bot commented Dec 5, 2019

Codecov Report

Merging #1037 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1037   +/-   ##
=======================================
  Coverage   88.27%   88.27%           
=======================================
  Files          67       67           
  Lines        6254     6254           
=======================================
  Hits         5521     5521           
  Misses        733      733

@mli
Copy link
Member

mli commented Dec 5, 2019

Job PR-1037/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1037/1/index.html

@leezu leezu merged commit 3ce9995 into dmlc:master Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when using fp16 trainer
3 participants