This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
[CI] Enable type checks and inference with pytype #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typing.NamedTuple is not a generic type that can be used as type annotation. Rather it's intended usage is for users to instantiate a specific NamedTuple class, which can then be used for typechecking.
Codecov Report
@@ Coverage Diff @@
## master #1018 +/- ##
==========================================
- Coverage 89.93% 89.91% -0.03%
==========================================
Files 67 67
Lines 6340 6333 -7
==========================================
- Hits 5702 5694 -8
- Misses 638 639 +1
|
leezu
force-pushed
the
pytype
branch
6 times, most recently
from
dfaa63b
to
3290eb0
Compare
Fixes use of uninitialized attributes in former base class
In that case `'NoneType' object is not callable` would be generated. Instead print a proper error.
|
Job PR-1018/10 is complete. |
szha
approved these changes
Nov 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pytype is a static type analyzer for Python code.
Checklist
Essentials
Changes
Comments
Later we can use the
merge-pyito integrate the inferred types into the codebase.cc @dmlc/gluon-nlp-team