Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Fix version check in train_gnmt.py and train_transformer.py #1003

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

leezu
Copy link
Contributor

@leezu leezu commented Nov 13, 2019

Description

Fix version check in train_gnmt.py and train_transformer.py

Fixes #1002

cc @dmlc/gluon-nlp-team

@leezu leezu requested a review from a team as a code owner November 13, 2019 04:09
@codecov
Copy link

codecov bot commented Nov 13, 2019

Codecov Report

Merging #1003 into master will increase coverage by 0.56%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1003      +/-   ##
==========================================
+ Coverage   89.29%   89.85%   +0.56%     
==========================================
  Files          67       67              
  Lines        6351     6351              
==========================================
+ Hits         5671     5707      +36     
+ Misses        680      644      -36
Impacted Files Coverage Δ
src/gluonnlp/model/attention_cell.py 95.06% <0%> (+1.23%) ⬆️
src/gluonnlp/model/block.py 53.19% <0%> (+2.12%) ⬆️
src/gluonnlp/model/transformer.py 91.31% <0%> (+4.5%) ⬆️
src/gluonnlp/model/seq2seq_encoder_decoder.py 75.38% <0%> (+29.23%) ⬆️

@mli
Copy link
Member

mli commented Nov 13, 2019

Job PR-1003/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1003/1/index.html

@eric-haibin-lin eric-haibin-lin merged commit c5855a8 into dmlc:master Nov 13, 2019
@leezu leezu deleted the fixversioncheck branch November 13, 2019 06:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportError: cannot import name 'Seq2SeqOneStepDecoder'
3 participants