feat: Add support for linking to section headings #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Always use selective imports * Use `imported` for one-off uses of a module * Delete unused imports * Reorder imports to start of the function
And use range algorithms in its implementation.
…tion headings With this change, links of the form `basics/delegates#anonymous-functions-lambdas` are no longer rejected. Instead, they're accepted and clicking on them leads to the browser navigating to the right page and highlighting the specific heading. This is done by: * Validating: stripping off the fragment part before checking of the given file exists * Adjusting the AngularJS (ng1) routing - enabling HTML5 mode (i.e. disabling the default "hashbang" mode) and disabling client-side URL rewriting * Adding a CSS rule to highlight the heading that the URL is linking to
|
std.process.ProcessException@std/process.d(905): Executable file not found: dmd |
|
Thx |
Needed for compatibility with vibe.d 0.96.0.
…name` to get an actual `string` Needed for compatibility with vibe.d 0.96.0.
PetarKirov
added a commit
to ntrel/english
that referenced
this pull request
Jul 31, 2023
This reverts commit cceb253. As of dlang-tour/core#783, we should be able to use URL fragments to link to specific headings, so the previous version of the code (that used them) is preferrable.
PetarKirov
added a commit
to ntrel/english
that referenced
this pull request
Jul 31, 2023
This reverts commit 1474fcd. As of dlang-tour/core#783, we should be able to use URL fragments to link to specific headings, so the previous version of the code (that used them) is preferrable.
PetarKirov
added a commit
to ntrel/english
that referenced
this pull request
Jul 31, 2023
This reverts commit 1474fcd. As of dlang-tour/core#783, we should be able to use URL fragments to link to specific headings, so the previous version of the code (that used them) is preferrable.
PetarKirov
added a commit
to ntrel/english
that referenced
this pull request
Jul 31, 2023
This reverts commit 1474fcd. As of dlang-tour/core#783, we should be able to use URL fragments to link to specific headings, so the previous version of the code (that used them) is preferrable.
PetarKirov
added a commit
to ntrel/english
that referenced
this pull request
Jul 31, 2023
This reverts commit 1474fcd. As of dlang-tour/core#783, we should be able to use URL fragments to link to specific headings, so the previous version of the code (that used them) is preferrable.
PetarKirov
added a commit
to ntrel/english
that referenced
this pull request
Jul 31, 2023
This reverts commit 1474fcd. As of dlang-tour/core#783, we should be able to use URL fragments to link to specific headings, so the previous version of the code (that used them) is preferrable.
PetarKirov
added a commit
to dlang-tour/english
that referenced
this pull request
Jul 31, 2023
This reverts commit 1474fcd. As of dlang-tour/core#783, we should be able to use URL fragments to link to specific headings, so the previous version of the code (that used them) is preferrable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, links of the form
basics/delegates#anonymous-functions-lambdasare no longer rejected. Instead, they're accepted and clicking on them leads to the browser navigating to the right page and highlighting the specific heading.This is done by:
dlang-tour-core-pr-783-linking-to-headings.webm