Expand make_mock_data projection options
#213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffjennings
commented
Nov 1, 2023
rbooth200
approved these changes
Nov 1, 2023
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds option in
make_mock_datato reproject rather than deprojected the generated mock data. Handles the expected behavior of the function from its previous implementation (when onlygeometrywas passed in order to deproject).This option is useful to quickly generate reprojected mock visibilities from a deprojected frank brightness profile in order to compare to observations or to external software like MPoL that works with projected data and performs its own implementation of deprojection.