LibreTranslate provider support

[pierotofy]

Hello ✋ !

This PR adds support for libretranslate (https://libretranslate.com) as a translation provider.

Hope this can be useful to others. Let me know if changes are needed.

Cheers! 🥂

[pierotofy]

Anyone home? 👋

[danir-de]

@discourse What happened here?

[sunjam]

@pierotofy try asking on https://meta.discourse.org/t/discourse-translator/32630 ❤️

Their meta forum is where all discussion happens.

[gdevenyi]

@pierotofy try asking on meta.discourse.org/t/discourse-translator/32630 heart

Same radio silence on the meta discourse as here, will this ever be merged?

[pierotofy]

I recommend people just use our fork at https://github.com/LibreTranslate/discourse-translator

[gdevenyi]

I've forked the original repo and merged the plugin into an upated branch here, https://github.com/gdevenyi/discourse-translator/tree/deploy

[pmusaraj]

Thanks @pierotofy, many apologies, we didn't see this earlier. It looks good, though, thank you!

Any chance you can grant Discourse (and send privately) an API key for testing? We don't run our own LibreTranslate instance and currently don't have the time to stand one up.

[tgxworld]

If anyone can write tests for this PR, we'll be happy to review and merge this.

[pierotofy]

You can use one of the open mirrors here to test this without needing an API key: https://github.com/LibreTranslate/LibreTranslate#mirrors

I've also updated the fork at https://github.com/LibreTranslate/discourse-translator with the latest changes for those that can't wait for this to be merged.

[bdecotte]

Hi @pierotofy , it seems SUPPORTED_LANG
https://github.com/LibreTranslate/discourse-translator/blob/c2067a2512ec942106ee81e57625d326ea334965/services/discourse_translator/libretranslate.rb#L10
has become SUPPORTED_LANG_MAPPING

discourse-translator/plugin.rb

Line 126 in d650f82

detected_lang != "DiscourseTranslator::#{SiteSetting.translator}::SUPPORTED_LANG_MAPPING".constantize[I18n.locale]

and the /languages url needs the GET method
https://github.com/LibreTranslate/discourse-translator/blob/c2067a2512ec942106ee81e57625d326ea334965/services/discourse_translator/libretranslate.rb#L81

[poVoq]

https://meta.discourse.org/t/discourse-translator/32630

claims Libre-translate is supported, but this isn't merged yet?

[pmusaraj]

Yes, that is correct. The meta topic points to the fork that has LibreTranslate support.

This PR needs a refactor before merging, see the comment by @bdecotte just above.

[satoshinotdead]

So, we are OK now? :)

[johnsonm]

@pmusaraj I note that the latest version has SUPPORTED_LANG_MAPPING now and it now has the GET method added.

Is there anything else in the way of merging this? (Well, other than there was no response when it was fixed and now there are conflicts...)

[pmusaraj]

Apologies for the very long delay here, all... but this is now approved and I am merging it. Thanks for all your work here!

I tested the feature locally using these steps:

pip3 install libretranslate # installs LibreTranslate

libtranslate # starts the service and on the first run it downloads dictionaries
ltmanage keys add 120 # adds an api key for use in the site settings

libtranslate --api-keys # optional, for testing the api key in the LibreTranslate UI