FEAT: Add more support and sync with Discourse allowed locales #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some
I18n.localeswhich are not mapped to Amazon available languages in https://docs.aws.amazon.com/translate/latest/dg/what-is-languages.html, important ones likeen_GB,pt_BR,zh_CN, etc. Not having these mappings would result in a 500 error due to absent param.This updates our mapping list to the locale's most appropriate mappings, and also rearranges the locales by alphabetical order.
(The 500 should be handled in a separate PR)