DEV: Scope guardian methods to the plugin and some cleanup #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattsw
force-pushed
the
rename-guardian-translator
branch
from
5074274
to
2322249
Compare
nattsw
changed the title
martin-brennan
approved these changes
May 3, 2024
| ) | ||
| return false | ||
| end | ||
| add_to_serializer :post, :can_translate do |
There was a problem hiding this comment.
You might want to add a include_condition here too to just check SiteSetting.translator_enabled
There was a problem hiding this comment.
From /t/92657 if we don't include define_include_method=false we won't need to check if the plugin is enabled since by default respect_plugin_enabled is true.
There was a problem hiding this comment.
Ahhh okay cool, good to know 👍
nattsw
force-pushed
the
rename-guardian-translator
branch
from
dd8f0f3
to
7e89003
Compare
|
Thank you @martin-brennan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While making some updates to the translator plugin, I found some generic guardian additions which could potentially cause conflicts. e.g.
guardian.user_group_allowed?->guardian.user_group_allow_translate?.This PR
SiteSetting.group_mapfunctions anduser.in_any_groupsfunctionsadd_to_serializer