FIX: Amazon text size is 10k bytes #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markvanlan
approved these changes
Apr 19, 2024
|
Would be good to have a test if possible 🤷 |
ZogStriP
force-pushed
the
fix-amazon-text-size
branch
from
f428976
to
60e052a
Compare
The Amazon translate API allows for a text to be up to 10k bytes. This changes the `MAXLENGTH` constant into the `MAX_BYTES` and uses a `truncate` method that works at the bytes level instead of the character/grapheme level. Ref - https://meta.discourse.org/t/increase-amazon-translate-limit-to-10-000-characters/304579
ZogStriP
force-pushed
the
fix-amazon-text-size
branch
from
60e052a
to
e9df920
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Amazon translate API allows for a text to be up to 10k bytes.
This changes the
MAXLENGTHconstant into theMAX_BYTESand uses atruncatemethod that works at the bytes level instead of the character/grapheme level.Ref - https://meta.discourse.org/t/increase-amazon-translate-limit-to-10-000-characters/304579